Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregation discards sync committee messages/attestations on delays when subnet wasn't created #1302

Open
rodrigo-o opened this issue Sep 20, 2024 · 0 comments
Labels
attester P2 This is a nice to have. Improves usability of the app or the libraries, but it's not urgent. sync committees

Comments

@rodrigo-o
Copy link
Collaborator

This issue is a follow-up of #1301, that issue is fixed right now, receiving messages before having the subnet created doesn't crash LibP2P anymore, we just discard them. The Subnet info data structure is create at the time of attesting or broadcasting a sync committee message, in the second third of the slot, some delays could make some messages being lost on aggregations, this could probe to be an issue in some not-so-common cases where we skip the second third altogether due to a delay and go directly to the aggregation step which in our case would be empty even when we actually received messages and attestations.

This is not a priority be we should be mindful of this in case we encounter the issue.

@rodrigo-o rodrigo-o added P2 This is a nice to have. Improves usability of the app or the libraries, but it's not urgent. attester sync committees labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attester P2 This is a nice to have. Improves usability of the app or the libraries, but it's not urgent. sync committees
Projects
Status: No status
Development

No branches or pull requests

1 participant