Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing attestations and sync committee messages due to late subnet subscription #1300

Open
rodrigo-o opened this issue Sep 19, 2024 · 1 comment · Fixed by #1298
Open

Missing attestations and sync committee messages due to late subnet subscription #1300

rodrigo-o opened this issue Sep 19, 2024 · 1 comment · Fixed by #1298
Assignees
Labels
attester bug Something isn't working P2 This is a nice to have. Improves usability of the app or the libraries, but it's not urgent. sync committees

Comments

@rodrigo-o
Copy link
Collaborator

rodrigo-o commented Sep 19, 2024

Previously part of #1279, I split the bug we were having from the leave and join that was made previously on duties calculations.

The bug is now this issue and it goes as follows:

Subscription to aggregation subnets happens just after attestation or sync committee broadcast, i.e. at the second third of a slot. There is also another place that could make produce this early and that's at the processing of a new block root. because of this, some sync committee messages and attestation were not part of aggregation, to solve this bug we need to subscribe as early as possible to the subnets that we need to be aware of.

@rodrigo-o
Copy link
Collaborator Author

Unfortunately, this still happens on specific setups were we are most of the validators in the network. This was solved on normal kurtosis runs (which had the particularity of having more than one aggregator per sync committee and ours were discarded) but we are still missing messages at the time of aggregation and its clear on cases were we are the only aggregators. I open this as a P2 given that this isn't a priority.

@rodrigo-o rodrigo-o reopened this Sep 26, 2024
@rodrigo-o rodrigo-o added the P2 This is a nice to have. Improves usability of the app or the libraries, but it's not urgent. label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attester bug Something isn't working P2 This is a nice to have. Improves usability of the app or the libraries, but it's not urgent. sync committees
Projects
1 participant