Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsubscribe from topics without leaving them #1289

Open
rodrigo-o opened this issue Sep 10, 2024 · 0 comments
Open

Unsubscribe from topics without leaving them #1289

rodrigo-o opened this issue Sep 10, 2024 · 0 comments
Labels
attester P2 This is a nice to have. Improves usability of the app or the libraries, but it's not urgent. sync committees

Comments

@rodrigo-o
Copy link
Collaborator

This was a TODO comment on attestations that impacts also sync_committees, right now to unsubscribe from a topi we need to leave an rejoin:

  @spec stop_collecting(non_neg_integer()) ::
          {:ok, list(Types.Attestation.t())} | {:error, String.t()}
  def stop_collecting(subnet_id) do
    topic = topic(subnet_id)
    Libp2pPort.leave_topic(topic)
    Libp2pPort.join_topic(topic)
    SyncSubnetInfo.stop_collecting(subnet_id)
  end
@rodrigo-o rodrigo-o added P2 This is a nice to have. Improves usability of the app or the libraries, but it's not urgent. attester sync committees labels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attester P2 This is a nice to have. Improves usability of the app or the libraries, but it's not urgent. sync committees
Projects
Status: Backlog
Development

No branches or pull requests

1 participant