Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version for flags without borders #38

Open
JimmyAXE opened this issue Jun 22, 2015 · 5 comments
Open

New version for flags without borders #38

JimmyAXE opened this issue Jun 22, 2015 · 5 comments

Comments

@JimmyAXE
Copy link

I just discover that you've removed those 1px light grey borders from all flags in latest commit (96a9bc8), which is fine, but could you please make a new version out of it? My older designs are suited for images with borders, so it looks weird now, especially when you've got a flag with white space on white background for example.

@aloxe
Copy link
Contributor

aloxe commented Jun 22, 2015

I see the problem you pointed and I made that change. Unfortunately it seams that my image editor doesn't read the shadows around flags and I can't figure out why. I need some help here.

@tudorpavel
Copy link

I also had some problems with that. But I think it wasn't because of Gimp itself, it was because of the compression step.

I'm not sure if this was my solution in the end, but I used the older uncompressed images, made my changes and compressed them afterwards with the same tool: https://compressor.io/compress.

The only problem is that this isn't really feasible for the future, as new flags are added, only if an uncompressed version is also kept up to date inside the repo. What do you think, @lafeber?

@lafeber
Copy link
Owner

lafeber commented Jun 23, 2015

Very good idea to have the uncompressed images in the repo! This ensures quality in the future. Plus, people may choose a higher quality image if they don't care about bandwidth or page speed.

@tudorpavel
Copy link

@lafeber, do you also have a PSD template or something like that with the glow&shadow effect of flags?

Including a template (maybe as a TIFF for compatibility) in the repo would also greatly simplify contribs such as @aloxe's.

@micky2be
Copy link

Any plan to add the shadows back?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants