Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected UI issues with Wagtail 3.0 release #193

Open
thibaudcolas opened this issue Apr 27, 2022 · 1 comment
Open

Expected UI issues with Wagtail 3.0 release #193

thibaudcolas opened this issue Apr 27, 2022 · 1 comment

Comments

@thibaudcolas
Copy link

Hi Lab Digital!The Wagtail 3.0 first release candidate is out. There are large UI changes in this release, for which we have reviewed expected breakage in third-party UI customisations.

This is beyond what we do with our normal breaking changes policy, since the majority of those changes are on parts of Wagtail that haven’t been publicly supported / documented in any way. To make sure this goes smoothly anyway, I’m here to provide an advance notice of what we’re aware of with this specific package 🙂

In the case of StreamForms, there are no confirmed issues, but I thought it would be worthwhile to give you a heads’up of what to manually review nonetheless.

Header template

We’ve made cosmetic changes to our header component. We expect it to work as-before otherwise, but it’s worth checking manually:

wagtail/labd/wagtailstreamforms/wagtailstreamforms/templates/streamforms/advanced_settings.html
8:    {% include "wagtailadmin/shared/header.html" with title=title_str subtitle=object icon="doc-empty-inverse" %}

wagtail/labd/wagtailstreamforms/wagtailstreamforms/templates/streamforms/confirm_copy.html
8:    {% include "wagtailadmin/shared/header.html" with title=copy_str subtitle=object.title icon="doc-empty-inverse" %}

wagtail/labd/wagtailstreamforms/wagtailstreamforms/templates/streamforms/confirm_delete.html
8:    {% include "wagtailadmin/shared/header.html" with title=del_str subtitle=object.title icon="doc-empty-inverse" %}

Core templates reuse

We’ve made a lot of styling and template changes to our base templates – it’s worth checking whether this affects any of those customisations:

wagtail/labd/wagtailstreamforms/wagtailstreamforms/templates/streamforms/advanced_settings.html
1:{% extends "wagtailadmin/base.html" %}
8:    {% include "wagtailadmin/shared/header.html" with title=title_str subtitle=object icon="doc-empty-inverse" %}
16:                        {% include "wagtailadmin/shared/field_as_li.html" %}

wagtail/labd/wagtailstreamforms/wagtailstreamforms/templates/streamforms/confirm_copy.html
1:{% extends "wagtailadmin/base.html" %}
8:    {% include "wagtailadmin/shared/header.html" with title=copy_str subtitle=object.title icon="doc-empty-inverse" %}
17:                        {% include "wagtailadmin/shared/field_as_li.html" %}

wagtail/labd/wagtailstreamforms/wagtailstreamforms/templates/streamforms/confirm_delete.html
1:{% extends "wagtailadmin/base.html" %}
8:    {% include "wagtailadmin/shared/header.html" with title=del_str subtitle=object.title icon="doc-empty-inverse" %}

wagtail/labd/wagtailstreamforms/wagtailstreamforms/templates/streamforms/index_submissions.html
1:{% extends "wagtailadmin/base.html" %}
6:    {% include "streamforms/wagtailadmin/shared/datetimepicker_translations.html" %}
80:                                {% include "wagtailadmin/shared/field_as_li.html" with field=field field_classes="field-small" li_classes="col4" %}

I hope this all makes sense. We’ve made a lot of other styling and template changes that are hard to track down, and for which it’s unclear whether any breakage might be expected or not. As you go through the Wagtail 3.0 compatibility work, please let me know if there are other compatibility issues you come across so we can consider those customisations in Wagtail development in the future, and let others know about those breakages.

@VdeJong
Copy link
Contributor

VdeJong commented Aug 8, 2022

This is great! Thanks for the heads-up. We will check these suggestions for sure. @thibaudcolas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants