Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not create a new Interface instance when updating #3

Closed
ajoaoff opened this issue Jun 7, 2021 · 1 comment
Closed

Do not create a new Interface instance when updating #3

ajoaoff opened this issue Jun 7, 2021 · 1 comment
Labels
2022.3 Kytos-ng 2022.3 bug Something isn't working

Comments

@ajoaoff
Copy link

ajoaoff commented Jun 7, 2021

Original issue opened by @ajoaoff at kytos#35.

When an event of port_change is received, do not create a new instance of Interface if one already exists, but update it.
@ajoaoff ajoaoff added bug Something isn't working pri:important labels Jun 7, 2021
@viniarck
Copy link
Member

viniarck commented Dec 5, 2022

I'll go ahead and close this issue.

As of now, we've been updating interfaces when handling port description or port status OFPPR_ADD:

https://github.com/kytos-ng/of_core/blob/master/v0x04/utils.py#L110

https://github.com/kytos-ng/of_core/blob/master/main.py#L591

@viniarck viniarck closed this as completed Dec 5, 2022
@italovalcy italovalcy added the 2022.3 Kytos-ng 2022.3 label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2022.3 Kytos-ng 2022.3 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@italovalcy @ajoaoff @viniarck