-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show angle of center bubble level #2767
Comments
|
I'm just a bit concerned that those are too mathematical (X and Y are already kind of there). |
If i can chime in, it probably is Theta θ because it is the resulting vector of the X and Y. If i place my phone on an angled surface, if i rotate my phones orientation but keep it on the surface, the X and Y will change based on where the top of the phone is oriented. But the Theta will always remain the same as it is a combination of the two vectors and how they combine to coordinate the bubble from the origin. Maybe V for vector? |
I think I will most likely just go with calling it "angle" since that's a common term. I feel like theta and vector may be too mathematical. |
And for reference, here's where that center angle is being calculated: Trail-Sense/app/src/main/java/com/kylecorry/trail_sense/tools/level/ui/BubbleLevel.kt Line 138 in 2916e43
(technically it's the centerPercent * 90, the centerAngle is just used to render this in polar coordinates) |
Draw the angle label on the center bubble level. Look into displaying this in the title as well (just call it angle?).
The text was updated successfully, but these errors were encountered: