Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show angle of center bubble level #2767

Open
kylecorry31 opened this issue Jan 9, 2025 · 6 comments
Open

Show angle of center bubble level #2767

kylecorry31 opened this issue Jan 9, 2025 · 6 comments
Labels
help wanted Open to community contribution at any time p4 Priority 4 tool-bubble-level

Comments

@kylecorry31
Copy link
Owner

Draw the angle label on the center bubble level. Look into displaying this in the title as well (just call it angle?).

@kylecorry31 kylecorry31 added help wanted Open to community contribution at any time p4 Priority 4 tool-bubble-level labels Jan 9, 2025
@michaelblyons
Copy link

michaelblyons commented Jan 10, 2025

r for radius?
Theta for angle?

@kylecorry31
Copy link
Owner Author

r for radius? Theta for angle?

I'm just a bit concerned that those are too mathematical (X and Y are already kind of there).

@darrencoen
Copy link

darrencoen commented Jan 10, 2025

If i can chime in, it probably is Theta θ because it is the resulting vector of the X and Y.

If i place my phone on an angled surface, if i rotate my phones orientation but keep it on the surface, the X and Y will change based on where the top of the phone is oriented. But the Theta will always remain the same as it is a combination of the two vectors and how they combine to coordinate the bubble from the origin.

image
image
image

image

Maybe V for vector?

@michaelblyons
Copy link

https://en.m.wikipedia.org/wiki/Polar_coordinate_system

@kylecorry31
Copy link
Owner Author

I think I will most likely just go with calling it "angle" since that's a common term. I feel like theta and vector may be too mathematical.

@kylecorry31
Copy link
Owner Author

kylecorry31 commented Jan 10, 2025

And for reference, here's where that center angle is being calculated:

val centerPercent = hypot(xAngle, yAngle).coerceAtMost(90f) / 90f

(technically it's the centerPercent * 90, the centerAngle is just used to render this in polar coordinates)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open to community contribution at any time p4 Priority 4 tool-bubble-level
Projects
None yet
Development

No branches or pull requests

3 participants