Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aesthetics: Make node border colors and arrowheads consistent with schema view #109

Closed
2 tasks done
prrao87 opened this issue Mar 18, 2024 · 5 comments · Fixed by #118
Closed
2 tasks done

Aesthetics: Make node border colors and arrowheads consistent with schema view #109

prrao87 opened this issue Mar 18, 2024 · 5 comments · Fixed by #118
Assignees

Comments

@prrao87
Copy link
Member

prrao87 commented Mar 18, 2024

#101 made the schema visualization really nice-looking. For the query browser, it would be nice to add a similar enhancement.

The following shows how it currently looks when returning a query result:

image

The schema view looks like this:

image

Changes

  • We should color the nodes for query results the same way as we do for the schema view: the border color should be a darker version of the node's background color. This would make it much nicer aesthetically and more similar to other graph visualization tools.
  • We should also make the arrowhead shapes in the query result similar to the schema view - having a filled triangle as the arrowhead (as we do in the schema view) looks better for a relationship visualization in a graph.
@prrao87 prrao87 changed the title Aesthetics: Color node border in query result like the schema view Aesthetics: Make node border colors and arrowheads consistent with schema view Mar 18, 2024
@mewim
Copy link
Member

mewim commented Mar 19, 2024

1 is handled by #115.
I checked 2 and it seems I did not do anything special to configure the edge style - it is simply an effect of line width. I will see if there is any alternative solution to override the arrow style.

@prrao87
Copy link
Member Author

prrao87 commented Mar 19, 2024

We could just increase the line width like we do in the schema. Same setting, same effect :)

@mewim
Copy link
Member

mewim commented Mar 19, 2024

We could just increase the line width like we do in the schema. Same setting, same effect :)

Since the viz for console is drawn on a smaller canvas, it might not be desirable to draw everything big. But maybe a tweak of pixel size + zooming level can create a good result. It'll require some tweaking.

@prrao87
Copy link
Member Author

prrao87 commented Mar 19, 2024

Seems like the arrowheads can be customized to triangle shape by using G6.Arrow.triangle per the docs

@mewim mewim linked a pull request Mar 20, 2024 that will close this issue
@mewim
Copy link
Member

mewim commented Mar 20, 2024

Screenshot 2024-03-20 at 8 11 27 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants