Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider self hosted runner for link checker job #2119

Open
slonka opened this issue Dec 10, 2024 · 2 comments
Open

Consider self hosted runner for link checker job #2119

slonka opened this issue Dec 10, 2024 · 2 comments
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@slonka
Copy link
Contributor

slonka commented Dec 10, 2024

Description

We're excluding more and more external links #2118 because of flakyness and other reasons. I think this is because different websites / CDNs / DDOS protection systems just ban traffic from GH IP ranges. We could try running these on self-hosted runners to see if that stabilises it.

Why is it important? It allows us to make sure we link to correct parts of the docs of things we integrate with. If they change their website and we don't adjust we're giving our user a bad experience. If we don't to anything with it we might as well disable all external link checking 🤷 .
@slonka slonka added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Dec 10, 2024
@slonka slonka mentioned this issue Dec 10, 2024
Open
@lukidzi
Copy link
Contributor

lukidzi commented Dec 16, 2024 •
edited
Loading

Triage: Let's have a scheduled job that runs on master and verify once a day (only for external links, internal are going to be checked on every pr). We can observe a status in project-report

@lukidzi lukidzi added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Dec 16, 2024
@lahabana
Copy link
Contributor

I think this is because different websites / CDNs / DDOS protection systems just ban traffic from GH IP ranges.
You think or you've seen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lahabana @slonka @lukidzi