Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installer.sh should only consider commits that are first ancestors of the current master #1668

Closed
michaelbeaumont opened this issue Feb 23, 2024 · 2 comments
Closed

installer.sh should only consider commits that are first ancestors of the current master #1668

michaelbeaumont opened this issue Feb 23, 2024 · 2 comments
Labels
kind/bug A bug triage/pending This issue will be looked at on the next triage meeting

Comments

@michaelbeaumont
Copy link
Contributor

Description

In the presence of merge commits, installer.sh will sometimes choose a commit from a PR branch that has been merged into master as the current preview version because:

  • it's in the history returned by the GraphQL API
  • it has a "green" status.

It should only consider commits that are first ancestors of the current master commit.
@michaelbeaumont michaelbeaumont added triage/pending This issue will be looked at on the next triage meeting kind/bug A bug labels Feb 23, 2024
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Feb 26, 2024
@lahabana
Copy link
Contributor

lahabana commented Apr 8, 2024

IIUC this #1710 fixes this issue.

@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting and removed triage/accepted The issue was reviewed and is complete enough to start working on it labels Apr 8, 2024
@michaelbeaumont
Copy link
Contributor Author

Yeah presumably gh run list doesn't return runs for commits on PR branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug triage/pending This issue will be looked at on the next triage meeting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lahabana @michaelbeaumont @jakubdyszkiewicz