Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Replatform] incremental build don't seem to work properly #1069

Closed
lahabana opened this issue Oct 26, 2022 · 10 comments
Closed

[Replatform] incremental build don't seem to work properly #1069

lahabana opened this issue Oct 26, 2022 · 10 comments
Labels
area/infra Anything related the inner workings rather of the site rather than content (Jekyll, CSS...) kind/bug A bug triage/rotten closed due to lack of information for too long, rejected feature...

Comments

@lahabana
Copy link
Contributor

What happened?

If I do a change in app/_data/docs_nav_kuma_dev.yml doing make build doesn't update the sidebar, I need to do make clean first.

@lahabana lahabana added triage/accepted The issue was reviewed and is complete enough to start working on it kind/bug A bug labels Oct 26, 2022
@fabianrbz
Copy link
Contributor

@lahabana thanks for opening the issue ❤️ .

Unfortunately, that's how the incremental flag works :/. You can read more about it here, tldr: it only tracks changes to documents or pages or to one of their dependencies - {% includes %} -.

However, you can force Jekyll to regenerate a page by adding regenerate: true to its frontmatter.
Another option is to remove the incremental flag entirely and it will pick up the changes every time. However, bear in mind that it takes ~25 seconds to build the whole site. There are some performance improvements that we would like to implement in order to reduce the build time, but we will tackle those after the release.

@lahabana lahabana added the area/infra Anything related the inner workings rather of the site rather than content (Jekyll, CSS...) label Oct 31, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jan 30, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Jan 30, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label May 1, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jul 31, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Jul 31, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Oct 30, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Oct 31, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jan 30, 2024
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@slonka
Copy link
Contributor

slonka commented Feb 7, 2024

Can't check this because I can't run the website locally :/ I'm assuming this is still the case.

image

@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label Feb 7, 2024
@slonka
Copy link
Contributor

slonka commented Feb 7, 2024

Was able to finally run the website. It seems that it has speed up, it's only 2.2 s

image

maybe we can do regenerate: true now?

@lahabana
Copy link
Contributor Author

lahabana commented Feb 9, 2024

Still needs clean to update sidebars. There's no easy way out so let's just close this.

@lahabana lahabana added triage/rotten closed due to lack of information for too long, rejected feature... and removed triage/accepted The issue was reviewed and is complete enough to start working on it labels Feb 9, 2024
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Automatically closing the issue due to having one of the "closed state label".

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra Anything related the inner workings rather of the site rather than content (Jekyll, CSS...) kind/bug A bug triage/rotten closed due to lack of information for too long, rejected feature...
Projects
None yet
Development

No branches or pull requests

4 participants