Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerShell install instructions in "Adding Windows worker nodes" use incorrect version #49423

Open
han-0315 opened this issue Jan 14, 2025 · 4 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. sig/windows Categorizes an issue or PR as relevant to SIG Windows. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@han-0315
Copy link

Hello,

I would like to contribute to improving the Kubernetes website. This is my first time submitting an issue, so please bear with me if I'm not following the standard procedures.

Improvement Suggestion:
In the install-kubeadm-and-kubelet section, there's a PowerShell command that currently specifies the Kubernetes version as v1.32. However, executing the command with v1.32 results in the following error:

DownloadFile : Download https://dl.k8s.io/v1.32/bin/windows/amd64/kubelet.exe failed

To resolve this issue, please update the KubernetesVersion parameter in the PrepareNode.ps1 script to use v1.32.0 instead of v1.32. The corrected command should look like this:

curl.exe -LO https://raw.githubusercontent.com/kubernetes-sigs/sig-windows-tools/master/hostprocess/PrepareNode.ps1
.\PrepareNode.ps1 -KubernetesVersion v1.32.0

Reason:
Using v1.32.0 ensures that the correct version is downloaded, preventing the aforementioned error.
Thank you for your attention to this matter.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 14, 2025
@dipesh-rawat
Copy link
Member

/retitle PowerShell install instructions in "Adding Windows worker nodes" use incorrect version
/kind bug

@k8s-ci-robot k8s-ci-robot changed the title Issue with k8s.io/docs/tasks/administer-cluster/kubeadm/adding-windows-nodes/ PowerShell install instructions in "Adding Windows worker nodes" use incorrect version Jan 14, 2025
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 14, 2025
@dipesh-rawat
Copy link
Member

Page reported in the issue: https://kubernetes.io/docs/tasks/administer-cluster/kubeadm/adding-windows-nodes
/language en

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 14, 2025
@dipesh-rawat
Copy link
Member

/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 14, 2025
@sftim
Copy link
Contributor

sftim commented Jan 14, 2025

/sig windows

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. sig/windows Categorizes an issue or PR as relevant to SIG Windows. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants