Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conformance tests for percentage-based request mirroring #3508

Merged
merged 5 commits into from
Jan 28, 2025
Merged

conformance tests for percentage-based request mirroring #3508

merged 5 commits into from
Jan 28, 2025

Conversation

LiorLieberman
Copy link
Member

@LiorLieberman LiorLieberman commented Dec 17, 2024 •
edited
Loading

What type of PR is this?
/kind test
/area conformance

What this PR does / why we need it:
Conformance tests for #3171 plus small updates to the GEP.
Tested with istio 1.24.1

Note: I also added a test case for fraction but it looks like it has an issue currently with the implementation I used (istio).

The specific test is failing, (which is good) so I think its in a good merge state. I also opened istio/istio#54357.

Mesh tests to follow

Which issue(s) this PR fixes:
Fixes #3171

Does this PR introduce a user-facing change?:

NONE

/cc @jakebennert @robscott

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/test area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 17, 2024
@k8s-ci-robot k8s-ci-robot added kind/gep PRs related to Gateway Enhancement Proposal(GEP) size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 17, 2024
@LiorLieberman LiorLieberman force-pushed the percent-based-mirror branch 3 times, most recently from 117f34b to d63225c Compare December 17, 2024 03:12
@LiorLieberman LiorLieberman changed the title initial conformance tests for percent based mirroring conformance tests for percentage-based request mirroring Dec 17, 2024
@LiorLieberman
Copy link
Member Author

/cc @jakebennert @robscott

@k8s-ci-robot
Copy link
Contributor

@LiorLieberman: GitHub didn't allow me to request PR reviews from the following users: jakebennert.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @jakebennert @robscott

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

robscott
robscott reviewed Dec 18, 2024
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LiorLieberman! This is really well done

conformance/tests/httproute-request-percentage-mirror.go Outdated Show resolved Hide resolved
conformance/tests/httproute-request-percentage-mirror.go Outdated Show resolved Hide resolved
conformance/tests/httproute-request-percentage-mirror.go Outdated Show resolved Hide resolved
conformance/tests/httproute-request-percentage-mirror.go Outdated Show resolved Hide resolved
geps/gep-3171/index.md Outdated Show resolved Hide resolved
geps/gep-3171/index.md Show resolved Hide resolved
@robscott
Copy link
Member

/cc @dprotaso

@LiorLieberman
Copy link
Member Author

/cc @kflynn

@k8s-ci-robot k8s-ci-robot requested a review from kflynn December 20, 2024 01:40
@LiorLieberman
Copy link
Member Author

ping @kflynn @dprotaso
/cc @mikemorris

mlavacca
mlavacca reviewed Jan 10, 2025
View reviewed changes
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @LiorLieberman!

pkg/features/httproute.go Outdated Show resolved Hide resolved
conformance/tests/httproute-request-percentage-mirror.go Show resolved Hide resolved
conformance/tests/httproute-request-percentage-mirror.go Outdated Show resolved Hide resolved
conformance/tests/httproute-request-percentage-mirror.go Outdated Show resolved Hide resolved
conformance/tests/httproute-request-percentage-mirror.go Outdated Show resolved Hide resolved
conformance/tests/httproute-request-percentage-mirror.go Outdated Show resolved Hide resolved
conformance/tests/httproute-request-percentage-mirror.go Show resolved Hide resolved
conformance/tests/httproute-request-percentage-mirror.go Show resolved Hide resolved
@LiorLieberman
Copy link
Member Author

@sayboras Can you help testing if CIlium passes this test?

/cc @sayboras

@k8s-ci-robot
Copy link
Contributor

@LiorLieberman: GitHub didn't allow me to request PR reviews from the following users: sayboras.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@sayboras Can you help testing if CIlium passes this test?

/cc @sayboras

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@robscott
Copy link
Member

Thanks @LiorLieberman!

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiorLieberman, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit eb75cda into kubernetes-sigs:main Jan 28, 2025
13 checks passed
@LiorLieberman LiorLieberman mentioned this pull request Jan 31, 2025
Open
@nfuden nfuden mentioned this pull request Feb 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont

@dprotaso dprotaso Awaiting requested review from dprotaso

@kflynn kflynn Awaiting requested review from kflynn

@mikemorris mikemorris Awaiting requested review from mikemorris

@robscott robscott Awaiting requested review from robscott

@mlavacca mlavacca Awaiting requested review from mlavacca

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gep PRs related to Gateway Enhancement Proposal(GEP) kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GEP: Percentage-Based Request Mirroring
4 participants
@LiorLieberman @k8s-ci-robot @robscott @mlavacca