✨ gitlab fetchConfig regexp #706
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @ts-mini. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
needs-ok-to-test
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ts-mini
force-pushed
the
tsmini.support-any-gitlab
branch
from
aef8fda to
9f3099d
Compare
k8s-ci-robot
added
size/S
ts-mini
force-pushed
the
tsmini.support-any-gitlab
branch
2 times, most recently
from
c29d9f1 to
90d55ab
Compare
ts-mini
force-pushed
the
tsmini.support-any-gitlab
branch
from
90d55ab to
63b6f1f
Compare
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
| @@ -641,6 +641,10 @@ func TestRepositoryFactory(t *testing.T) { | |||
| name: "gitlab repo", | |||
| fetchURL: "https://gitlab.example.org/api/v4/projects/group%2Fproject/packages/generic/cluster-api-proviver-aws/v1.4.1/path", | |||
| }, | |||
| { | |||
| name: "gitlab hyphenated repo", | |||
| fetchURL: "https://gitlab-test.example.org/api/v4/projects/group%2Fproject/packages/generic/cluster-api-proviver-aws/v1.4.1/path", | |||
There was a problem hiding this comment.
This is a pretty good idea, but it is a special case.
For example, our private GitLab instance called git.domain.name can't be changed and no gitlab prefix or postfix in name.
It would be nice to have some sort of option which can say that it's a GitLab instance if there is not possible to define it from the FQDN.
But seems to community should define is if suitable approach or not.
What this PR does / why we need it: The current implementation of the gitlab check uses HasPrefix - which doesn't allow for a gitlab whose domain could be different (gitlab-example.domain.com)
Which issue(s) this PR fixes:
Fixes #705