Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow both urllib3 1 and urllib3 2 in the kubernetes python package #2129

Closed
gibsondan opened this issue Sep 28, 2023 · 0 comments · Fixed by #2131
Closed

Allow both urllib3 1 and urllib3 2 in the kubernetes python package #2129

gibsondan opened this issue Sep 28, 2023 · 0 comments · Fixed by #2131
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@gibsondan
Copy link

gibsondan commented Sep 28, 2023

What is the feature and why do you need it:
27459d5 implies that the urllib3 pin was added because google-auth doesn't support urllib3 2. However, as of the latest release earlier this week, google-auth now supports that version: googleapis/google-auth-library-python#1389 (comment) (in fact, it has a lower bound pin, although they are in the process of changing that). I believe that change can now be reverted.

Describe the solution you'd like to see:
The kubernetes package supporting both urllib3 1 and urllib3 2.

@gibsondan gibsondan added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant