Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crd-model-gen:v1.0.6 hasn't been updated in three years #3712

Open
misterikkit opened this issue Sep 27, 2024 · 5 comments
Open

crd-model-gen:v1.0.6 hasn't been updated in three years #3712

misterikkit opened this issue Sep 27, 2024 · 5 comments

Comments

@misterikkit
Copy link
Contributor

Describe the bug
The container ghcr.io/kubernetes-client/java/crd-model-gen:v1.0.6 is 3 years old and makes use of a similarly aged KiND version, v0.11.1. Some security tools are flagging these old files as vulnerable. e.g.

$ docker run --rm -it --entrypoint kind ghcr.io/kubernetes-client/java/crd-model-gen:v1.0.6 version
kind v0.11.1 go1.16.4 linux/amd64

Continuing to use this for java codegen may become impossible in environments where I cannot control what security scans run or their strictness.

@brendandburns
Copy link
Contributor

You can always regenerate the image as needed using the script here:
https://github.com/kubernetes-client/java/blob/master/scripts/publish-crd-model-gen-image.sh

and the Dockerfile here:
https://github.com/kubernetes-client/java/blob/master/client-java-contrib/Dockerfile

We'd welcome a PR updating the version of kind that is used.

Most people don't need to use this script unless they are generating their own CRD code.

@misterikkit
Copy link
Contributor Author

@brendandburns Thanks for the quick reply.

You can always regenerate the image

I must be misunderstanding, as I surely don't have push permissions to that container repo. Or git tags in this repo.

We'd welcome a PR updating the version of kind that is used.

I'd be glad to bump this to a v1.0.7 but would need coordination with a maintainer to get appropriate tags in place, etc.

Most people don't need to use this script unless they are generating their own CRD code.

We are using this workflow so that java clients can interact with golang controllers. (CRD yaml is generated from golang structs)

@misterikkit
Copy link
Contributor Author

Oh it seems that HEAD is currently meant to use KiND v0.17.0 due to some improvements from @kozjan

As for publishing a new image, I found two scripts, neither of which seem to ever run. (one is hard-coded to v1.0.0 and the other v2.0.0)

https://github.com/kubernetes-client/java/blob/master/scripts/publish-crd-model-gen-image.sh
https://github.com/kubernetes-client/java/blob/master/client-java-contrib/publish-gen-image.sh

@brendandburns
Copy link
Contributor

You can push the image to your own registry and then modify the workflow that you referenced to point to your image, instead of the ghcr one.

If you want to add this parameterization to those scripts, we'd be happy to take those PRs.

@misterikkit
Copy link
Contributor Author

Much obliged. Parametrization proposed per pull petition #3716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants