From fcd7a8f8b3041d2bb593ac973e8bfc8ea072ad23 Mon Sep 17 00:00:00 2001
From: Greg Sheremeta <gshereme@redhat.com>
Date: Mon, 21 Oct 2024 16:08:44 -0400
Subject: [PATCH] fix(ui): turn off GKE metadata by default

Since GKE is only one of many platforms, change the default value
of `DISABLE_GKE_METADATA` to `true`. Edit the gcp manifest to override
that to `false` on GCP.

Fixes: #11247

Signed-off-by: Greg Sheremeta <gshereme@redhat.com>
---
 frontend/server/configs.ts                          |  2 +-
 .../kustomize/env/gcp/gcp-configurations-patch.yaml | 13 +++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/frontend/server/configs.ts b/frontend/server/configs.ts
index 4188338498f..b4ce780b7c2 100644
--- a/frontend/server/configs.ts
+++ b/frontend/server/configs.ts
@@ -101,7 +101,7 @@ export function loadConfigs(argv: string[], env: ProcessEnv): UIConfigs {
     /** The main container name of a pod where logs are retrieved */
     POD_LOG_CONTAINER_NAME = 'main',
     /** Disables GKE metadata endpoint. */
-    DISABLE_GKE_METADATA = 'false',
+    DISABLE_GKE_METADATA = 'true',
     /** Enable authorization checks for multi user mode. */
     ENABLE_AUTHZ = 'false',
     /** Deployment type. */
diff --git a/manifests/kustomize/env/gcp/gcp-configurations-patch.yaml b/manifests/kustomize/env/gcp/gcp-configurations-patch.yaml
index 5e725b536d2..79af1321cab 100644
--- a/manifests/kustomize/env/gcp/gcp-configurations-patch.yaml
+++ b/manifests/kustomize/env/gcp/gcp-configurations-patch.yaml
@@ -20,3 +20,16 @@ spec:
                 configMapKeyRef:
                   name: pipeline-install-config
                   key: gcsProjectId
+---
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+  name: ml-pipeline-ui
+spec:
+  template:
+    spec:
+      containers:
+        - name: ml-pipeline-ui
+          env:
+            - name: DISABLE_GKE_METADATA
+              value: 'false'