Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Actions Failure by Installing go-gitlint #134

Closed
wants to merge 1 commit into from

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Dec 28, 2023

PR Feedback (click)

  • 👍 Sweep Did Well
  • 👎 Sweep Needs Improvement
    I created this PR to fix the failing GitHub Actions.## Description
    This PR fixes the GitHub Actions failure that was caused by the go-gitlint tool not being found. The tool is used in the commit-msg githook to enforce coding standards on commit messages. The error suggested running 'make tools' or 'make tools.verify.go-gitlint' to install the tool, but this was not being done in the GitHub Actions workflow.

Summary of Changes

  • Added a new step to the GitHub Actions workflow in .github/workflows/main.yml that installs the go-gitlint tool. This step runs before the githooks are executed.
  • The new step runs the command 'make tools' or 'make tools.verify.go-gitlint', as suggested in the error message.
  • Ensured that this step is run in the correct environment, with access to the necessary dependencies and permissions.

After these changes, the GitHub Actions workflow should be able to find and use the go-gitlint tool, and the githooks should execute without errors.

@sweep-ai sweep-ai bot requested review from cubxxw and kubbot as code owners December 28, 2023 20:12
Copy link
Contributor Author

sweep-ai bot commented Dec 28, 2023

Rollback Files For Sweep

  • Rollback changes to .github/workflows/main.yml

@sweep-ai sweep-ai bot added the sweep label Dec 28, 2023
Copy link
Contributor Author

sweep-ai bot commented Dec 28, 2023

Sandbox Executions

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 28, 2023
@kubbot
Copy link
Member

kubbot commented Dec 28, 2023

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Sandbox Executions

Copy link
Contributor Author

sweep-ai bot commented Dec 28, 2023

Sweeping

Fixing PR: track the progress here.

I'm currently fixing this PR to address the following:

[Sweep GHA Fix] The GitHub Actions run failed with the following error logs:

The command:
Run git add .
yielded the following error:
##[error]Process completed with exit code 1.

Here are the logs:
�[93mkubecub : Running local kubecub pre-commit hook.�[0m
�[93mkubecub : Running the kubecub commit-msg hook.�[0m
.git/hooks/commit-msg: line 55: ./_output/tools/go-gitlint: No such file or directory
�[31mkubecub : ./_output/tools/go-gitlint not found. Please run 'make tools' OR 'make tools.verify.go-gitlint' make verto install it.�[0m
�[31mkubecub : Please fix your commit message to match kubecub coding standards�[0m
�[31mkubecub : https://gist.github.com/cubxxw/126b72104ac0b0ca484c9db09c3e5694#file-githook-md�[0m

Making changes according to plan... (step 3/3)

Copy link
Contributor Author

sweep-ai bot commented Dec 28, 2023

Sweeping

Fixing PR: track the progress here.

I'm currently fixing this PR to address the following:

[Sweep GHA Fix] The GitHub Actions run failed with the following error logs:

The command:
Run ./tools/typos ./CONTRIBUTING.md ./README.md
yielded the following error:
##[error]Process completed with exit code 127.

Here are the logs:
/home/runner/work/_temp/4f6b3d6b-d294-4168-b8c0-99c35029dfe3.sh: line 1: ./tools/typos: No such file or directory

Making changes according to plan... (step 3/3)

Copy link
Contributor Author

sweep-ai bot commented Dec 28, 2023

❌ Could not find files to change

Please join our Discord to report this issue.

@kubbot kubbot removed the sweep label Dec 30, 2023
@kubbot
Copy link
Member

kubbot commented Jan 31, 2024

This issue is stale because it has been open 7 days with no activity.

@kubbot kubbot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 31, 2024
@kubbot
Copy link
Member

kubbot commented Feb 5, 2024

This PR was closed because it has been stalled for 5 days with no activity. You can reopen it if you want.

@kubbot kubbot closed this Feb 5, 2024
@kubecub kubecub locked and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants