-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add whitelist filters to commands #65
Comments
This should hold until #90 is complete which will simplify this issue substantially. |
@michaelmdresser Closing out as #90 is complete. Please reopen if needed. |
This is an uncompleted improvement, so I'm reopening. #90 just moved the backing API to something that supports filtering. We still need to do the extra bit of work to add filtering flag(s) to |
Now that we have "v2 filters" I think we can just expose a standard filter string that gets passed to the backend! Example usage: Filter language docs: https://github.com/kubecost/docs/blob/main/filters-api.md. Shouldn't be too necessary because the BE handles all parsing. Just pass the string to the |
I'd like to take a look on this if the issue is still relevant. Note that the filter language docs link does not work anymore. |
This is certainly still relevant. The current docs link is https://docs.kubecost.com/apis/filters-api. It is my strong recommendation to "Just pass the string to the |
We currently provide no way to filter output, something like
kubectl cost namespace --whitelist ns1,ns2,ns3
which would only display cost data for namespacesns1
,ns2
, andns3
.The backing
/aggregatedCostModel
API provides filtering and so does the/allocation
API.They do so in different ways, however, making this a little more complicated than just passing a filter through to the API call.
The text was updated successfully, but these errors were encountered: