Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenCost dependency is old #166

Closed
mattray opened this issue Feb 19, 2024 · 1 comment · Fixed by #177
Closed

OpenCost dependency is old #166

mattray opened this issue Feb 19, 2024 · 1 comment · Fixed by #177
Assignees
@cliffcolvin

Comments

@mattray
Copy link
Contributor

mattray commented Feb 19, 2024

https://github.com/kubecost/kubectl-cost/blob/main/go.mod#L9

I bring this up because 1.108 had a substantial refactor and we probably can't just bump up the version to the latest
@michaelmdresser
Copy link
Contributor

Good point! kubectl-cost should only depend on opencost/core, so we'll have to update some imports but we'll likely benefit from a reduced dependency footprint.

@cliffcolvin cliffcolvin self-assigned this Sep 18, 2024
@cliffcolvin cliffcolvin mentioned this issue Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cliffcolvin cliffcolvin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump go, bump deps for cve, bump opencost and move to opencost/core kubecost/kubectl-cost
3 participants
@mattray @michaelmdresser @cliffcolvin