Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0.0] 학과 선택 / 편집 UI 구현 #58

Merged
merged 3 commits into from
Nov 26, 2023
Merged

[2.0.0] 학과 선택 / 편집 UI 구현 #58

merged 3 commits into from
Nov 26, 2023

Conversation

x-0o0
Copy link
Contributor

@x-0o0 x-0o0 commented Nov 24, 2023

학과 선택 학과 편집
Simulator Screenshot - iPhone 15 Pro - 2023-11-24 at 16 03 04 Simulator Screenshot - iPhone 15 Pro - 2023-11-24 at 16 00 05

학과선택

  • 공지리스트 --modal--> 학과 선택 뷰
  • 학과선택뷰 --dismiss--> 공지리스트 --push--> 학과편집뷰

NOTE:

@lgvv 님이 공지리스트 브랜치에서 작업한 코드를 새로운 브랜치로 분리하고 색상 수정과 연결되지 않은 액션 추가 작업을 했습니다.

@x-0o0 x-0o0 self-assigned this Nov 24, 2023
@x-0o0 x-0o0 added the 학과 학과 관련 기능 (학과 검색, 내학과) label Nov 24, 2023
@x-0o0 x-0o0 linked an issue Nov 24, 2023 that may be closed by this pull request
[2.0.0] 학과 선택 / 편집 화면 UI 작업 #59
Closed
2 tasks
@x-0o0
Copy link
Contributor Author

x-0o0 commented Nov 24, 2023 •
edited
Loading

TODO DONE

#17 내용도 반영하기

@x-0o0 x-0o0 marked this pull request as draft November 24, 2023 07:14
@x-0o0 x-0o0 mentioned this pull request Nov 24, 2023
Closed
@x-0o0 x-0o0 marked this pull request as ready for review November 24, 2023 07:43
@x-0o0
Copy link
Contributor Author

x-0o0 commented Nov 24, 2023

/쿠링 ios17 앱 빌드하고 패키지 빌드

@github-actions GitHub Actions
Copy link

🔨 iOS 16.2 iPhone 14 Pro 에서 스위프트 패키지를 빌드합니다.

@github-actions GitHub Actions
Copy link

🔨 iOS 17.0 iPhone 14 Pro 에서 쿠링 앱을 빌드합니다.

@github-actions GitHub Actions
Copy link

📬 iOS17 에서 앱 타겟 빌드에 실패했습니다. Actions에서 실패 결과를 확인해주세요.

@github-actions GitHub Actions
Copy link

✅ 패키지를 성공적으로 빌드했습니다.

@x-0o0
Copy link
Contributor Author

x-0o0 commented Nov 24, 2023

/쿠링 ios17 앱 빌드

@github-actions GitHub Actions
Copy link

🔨 iOS 17.0 iPhone 14 Pro 에서 쿠링 앱을 빌드합니다.

@github-actions GitHub Actions
Copy link

📬 iOS17 에서 앱 타겟 빌드에 실패했습니다. Actions에서 실패 결과를 확인해주세요.

@x-0o0
Copy link
Contributor Author

x-0o0 commented Nov 24, 2023

깃헙 액션 에러 내용

/Users/runner/work/ios-app/ios-app/KuringApp/KuringApp.xcodeproj: error: No profiles for 'com.kuring.service' were found: Xcode couldn't find any iOS App Development provisioning profiles matching 'com.kuring.service'. Automatic signing is disabled and unable to generate a profile. To enable automatic signing, pass -allowProvisioningUpdates to xcodebuild. (in target 'KuringApp' from project 'KuringApp')

@x-0o0
Copy link
Contributor Author

x-0o0 commented Nov 26, 2023

/쿠링 머지

@github-actions github-actions bot added the automerge auto merge 를 수동으로 미리 활성화 하는 경우 라벨을 추가해줘야 합니다. "/쿠링 머지" 실행시 자동으로 추가. label Nov 26, 2023
@github-actions github-actions bot merged commit 05d7f66 into develop/2.0.0 Nov 26, 2023
@github-actions github-actions bot deleted the feature/jaesung/department-selector branch November 26, 2023 05:08
@github-actions GitHub Actions
Copy link

🕊️ PR #58이 머지되었습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunshiningsoo sunshiningsoo sunshiningsoo approved these changes

@lgvv lgvv Awaiting requested review from lgvv

Assignees

@x-0o0 x-0o0

Labels
automerge auto merge 를 수동으로 미리 활성화 하는 경우 라벨을 추가해줘야 합니다. "/쿠링 머지" 실행시 자동으로 추가. 학과 학과 관련 기능 (학과 검색, 내학과)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2.0.0] 학과 선택 / 편집 화면 UI 작업
2 participants
@x-0o0 @sunshiningsoo