Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #31: Enable anchor links for kroxylicious.io #36

Merged
merged 10 commits into from
Feb 7, 2024

Conversation

k-wall
Copy link
Contributor

@k-wall k-wall commented Feb 1, 2024

It looks like this:

image

css/code.css Outdated Show resolved Hide resolved
css/code.css Outdated Show resolved Hide resolved
Copy link
Contributor

@gracegrimwood gracegrimwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've submitted a PR to adjust a few things, the details are in the PR description :)

@k-wall
Copy link
Contributor Author

k-wall commented Feb 5, 2024

@gracegrimwood thank you.

One issue, can we make the anchoring relative to the black title area? In this case I would expect the "What is Kroxylicious" to be displayed immediately beneath the black title area.

Do you know the right way to fix this?

image

@gracegrimwood
Copy link
Contributor

Took some digging because the usual solution (having the anchor link to an invisible div offset vertically up the page from the heading) isn't available to us because of the way we're injecting these anchors into the page. Turns out we can do it with the scroll-margin-top property instead, so I've submitted a PR to fix that here.

fix sticky header collapse, add scroll margin to content
@k-wall k-wall merged commit 8b00f15 into kroxylicious:main Feb 7, 2024
@k-wall k-wall deleted the issue-31 branch February 7, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it easy for readers to report problems with content or suggest fixes. Anchor links for kroxylicious.io
2 participants