-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #31: Enable anchor links for kroxylicious.io #36
Conversation
Signed-off-by: kwall <[email protected]>
… purpose to CSS and SASS files
…ading, therefore if anchor is hover heading is also hover)
…sition time so icon doesn't linger after cursor is removed, use color transitions to give fade/highlight effect, retain visibility transition for screen readers)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've submitted a PR to adjust a few things, the details are in the PR description :)
Issue 31 fixes
@gracegrimwood thank you. One issue, can we make the anchoring relative to the black title area? In this case I would expect the "What is Kroxylicious" to be displayed immediately beneath the black title area. Do you know the right way to fix this? |
Took some digging because the usual solution (having the anchor link to an invisible div offset vertically up the page from the heading) isn't available to us because of the way we're injecting these anchors into the page. Turns out we can do it with the |
fix sticky header collapse, add scroll margin to content
It looks like this: