Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use service loader to find KafkaCluster implementations #210

Open
k-wall opened this issue Oct 25, 2023 · 0 comments
Open

Use service loader to find KafkaCluster implementations #210

k-wall opened this issue Oct 25, 2023 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed triaged

Comments

@k-wall
Copy link
Contributor

k-wall commented Oct 25, 2023

It occurs to me that the junit ext ought to be applying the service loader pattern to KafkaCluster with container and in-vm implementations contributed from separate modules. The common code that relies on kafka server classes should looked at with a view to eliminating the dependency (mostly config constants IIRC). That way, if a user wanted to exclusively use the container-based implementation, they could avoid the kafka-server dependencies completely.

Like I say, I don't see any pressing need to do this now, but wanted to share the idea.

Originally posted by @k-wall in #206 (comment)

@k-wall k-wall changed the title Excellent point. I needed to read up. I found https://medium.com/@danismaz.furkan/difference-between-optional-true-optional-and-scope-provided-scope-7404ec24fb59 helpful. Use service loader to find KafkaCluster implementations Oct 25, 2023
@k-wall k-wall added enhancement New feature or request help wanted Extra attention is needed labels Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed triaged
Projects
None yet
Development

No branches or pull requests

2 participants