Feature request: Switching between classes by theme

[ukeloop]

I would like to have the ability to set a Theme for each form and switch the classes, etc. listed in the config.

[rudiedirkx]

Sounds good. Sounds like a PR!

[ukeloop]

Do you think we should always not include template_prefix in Templates? If Templates has template_prefix, it's duplicated.

[rudiedirkx]

Eh? Do you mean template_prefix in the config file? I don't use it, but it works, right?

[ukeloop]

I would like to change the view file as well for each Theme.

return [
    'themes' => [
        'default' => [
            // ...

            'template_prefix' => 'laravel-form-builder::',
        ],
        'foo' => [
            // ...

            'template_prefix' => 'forms.foo.',
        ],
    ],

    // ...
];

Templates doesn't need have template prefix.

[rudiedirkx]

I don't get it. What is Templates?

It's dangerous to change the entire config structure. That would probably break bc.

[ukeloop]

So it is not PR, it's issue.

If it is difficult to change only class, as in the case of Horizontal form, it is necessary to change view files.

I currently use form_label and form_widget instead of form_row when I need a form with a special layout.

[rudiedirkx]

I use form and row classes and custom CSS to do different layouts. There's many ways to do this. And every dev can do them. How much effort do you want to put into themes that won't work for everyone, but have to work for more than just yourself?

[ukeloop]

But Symfony form can change view files by theme.

[rudiedirkx]

This form builder isn't much like Symfony anymore. But you can PR anything you like, and if it's backward compatible, we might add it. That's the most important IMO: backward compatible.