Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use 1/998 for swap rows rather than 4/9 #306

Closed
leeoniya opened this issue Nov 20, 2017 · 5 comments
Closed

use 1/998 for swap rows rather than 4/9 #306

leeoniya opened this issue Nov 20, 2017 · 5 comments

Comments

@leeoniya
Copy link
Contributor

leeoniya commented Nov 20, 2017 •
edited
Loading

@krausest

i did a bit of testing as a followup to #305 (comment)

dunno if you wanna sneak this change into Round 7, but the results are rather revealing:

swap-rows
@leeoniya
Copy link
Contributor Author

leeoniya commented Nov 20, 2017 •
edited
Loading

the plot thickens...

apparently some libs are micro-optimized only for leading/trailing swapping rather than general swappage. so when we switch to 1/998 instead of 0/999, we get to see prettier autumn colors:

swap-rows2

@leeoniya leeoniya changed the title use 0/999 for swap rows rather than 4/9 use 1/998 for swap rows rather than 4/9 Nov 20, 2017
This was referenced Nov 20, 2017
Closed
Merged
@krausest
Copy link
Owner

Will run the swap benchmark and post results this evening.

@krausest
Copy link
Owner

Here they are.

@leeoniya
Copy link
Contributor Author

hmm, is choo v6.5.0-keyed misclassified?

@krausest
Copy link
Owner

Thanks for spotting it. At least its naming was already correct...
Fixed in ee308dc

@trotyl trotyl mentioned this issue Mar 5, 2018
Closed
@leeoniya leeoniya mentioned this issue Jun 15, 2023
Closed
@mohammedzamakhan mohammedzamakhan mentioned this issue Dec 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leeoniya @krausest