From c66dedae7efd8920d2e6cf09ba4ba0432f068d60 Mon Sep 17 00:00:00 2001 From: Steellow Date: Sun, 17 Oct 2021 18:42:38 +0300 Subject: [PATCH 01/12] Update link focus style --- src/js/components/Link.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/js/components/Link.js b/src/js/components/Link.js index 93b317c..1438a10 100644 --- a/src/js/components/Link.js +++ b/src/js/components/Link.js @@ -3,7 +3,12 @@ import { apply, tw } from 'twind' export default ({ children, class: classes = '', href, ...rest }) => html` Date: Sun, 17 Oct 2021 18:42:55 +0300 Subject: [PATCH 02/12] Change a tags to Link component --- src/js/components/Player.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/js/components/Player.js b/src/js/components/Player.js index 0618552..0a8d279 100644 --- a/src/js/components/Player.js +++ b/src/js/components/Player.js @@ -1,17 +1,20 @@ import { html } from 'htm/preact' import char from '../data/char' +import Link from './Link' export default () => html`

Soitin tulossa pian${char.trade}! Sitä ennen voit kuunnella podia mm.${' '} - + <${Link} href="https://open.spotify.com/show/1st4zWhHxzXn345vqdTfk8"> Spotifyssa - + ${' ja '} - + <${Link} + href="https://podcasts.apple.com/us/podcast/koodikrapula/id1572320652" + > Apple Podcastsissa - + .

` From f6f599e47a13041cc96a59a61aa819ad81a9ba8b Mon Sep 17 00:00:00 2001 From: Steellow Date: Mon, 18 Oct 2021 14:02:07 +0300 Subject: [PATCH 03/12] Redirect koodikrapula.fi/kysy to g-forms --- netlify.toml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/netlify.toml b/netlify.toml index 013cbb9..85a37c6 100644 --- a/netlify.toml +++ b/netlify.toml @@ -27,6 +27,10 @@ from = "https://krapu.la/kysy" to = "https://forms.gle/uyh3v8bbQUwnizEw5" status = 302 +[[redirects]] + from = "https://koodikrapula.fi/kysy" + to = "https://forms.gle/uyh3v8bbQUwnizEw5" + status = 302 [[redirects]] from = "https://koodikrapula.netlify.app/*" From 25c13d7ae7d529cf33aaf1441159b917fc4dec14 Mon Sep 17 00:00:00 2001 From: Steellow Date: Mon, 18 Oct 2021 15:35:03 +0300 Subject: [PATCH 04/12] Try to use mila (not working) --- package-lock.json | 118 ++++++++++++++++++++++++++++------ package.json | 2 + src/js/components/Markdown.js | 4 +- src/js/utils/markdownIt.js | 15 +++++ 4 files changed, 120 insertions(+), 19 deletions(-) create mode 100644 src/js/utils/markdownIt.js diff --git a/package-lock.json b/package-lock.json index d5bb869..4c2f981 100644 --- a/package-lock.json +++ b/package-lock.json @@ -21,6 +21,8 @@ "eslint-plugin-unicorn": "^33.0.1", "esm": "^3.2.25", "htm": "^3.0.4", + "markdown-it": "^12.2.0", + "markdown-it-link-attributes": "^3.0.0", "preact": "^10.5.13", "preact-render-to-string": "^5.1.19", "prettier": "2.3.2", @@ -89,6 +91,29 @@ "url": "https://opencollective.com/11ty" } }, + "node_modules/@11ty/eleventy/node_modules/linkify-it": { + "version": "2.2.0", + "resolved": "https://registry.npmjs.org/linkify-it/-/linkify-it-2.2.0.tgz", + "integrity": "sha512-GnAl/knGn+i1U/wjBz3akz2stz+HrHLsxMwHQGofCDfPvlf+gDKN58UtfmUquTY4/MXeE2x7k19KQmeoZi94Iw==", + "dependencies": { + "uc.micro": "^1.0.1" + } + }, + "node_modules/@11ty/eleventy/node_modules/markdown-it": { + "version": "10.0.0", + "resolved": "https://registry.npmjs.org/markdown-it/-/markdown-it-10.0.0.tgz", + "integrity": "sha512-YWOP1j7UbDNz+TumYP1kpwnP0aEa711cJjrAQrzd0UXlbJfc5aAq0F/PZHjiioqDC1NKgvIMX+o+9Bk7yuM2dg==", + "dependencies": { + "argparse": "^1.0.7", + "entities": "~2.0.0", + "linkify-it": "^2.0.0", + "mdurl": "^1.0.1", + "uc.micro": "^1.0.5" + }, + "bin": { + "markdown-it": "bin/markdown-it.js" + } + }, "node_modules/@babel/code-frame": { "version": "7.12.11", "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.12.11.tgz", @@ -3434,9 +3459,9 @@ "integrity": "sha1-HADHQ7QzzQpOgHWPe2SldEDZ/wA=" }, "node_modules/linkify-it": { - "version": "2.2.0", - "resolved": "https://registry.npmjs.org/linkify-it/-/linkify-it-2.2.0.tgz", - "integrity": "sha512-GnAl/knGn+i1U/wjBz3akz2stz+HrHLsxMwHQGofCDfPvlf+gDKN58UtfmUquTY4/MXeE2x7k19KQmeoZi94Iw==", + "version": "3.0.3", + "resolved": "https://registry.npmjs.org/linkify-it/-/linkify-it-3.0.3.tgz", + "integrity": "sha512-ynTsyrFSdE5oZ/O9GEf00kPngmOfVwazR5GKDq6EYfhlpFug3J2zybX56a2PRRpc9P+FuSoGNAwjlbDs9jJBPQ==", "dependencies": { "uc.micro": "^1.0.1" } @@ -3620,13 +3645,13 @@ } }, "node_modules/markdown-it": { - "version": "10.0.0", - "resolved": "https://registry.npmjs.org/markdown-it/-/markdown-it-10.0.0.tgz", - "integrity": "sha512-YWOP1j7UbDNz+TumYP1kpwnP0aEa711cJjrAQrzd0UXlbJfc5aAq0F/PZHjiioqDC1NKgvIMX+o+9Bk7yuM2dg==", + "version": "12.2.0", + "resolved": "https://registry.npmjs.org/markdown-it/-/markdown-it-12.2.0.tgz", + "integrity": "sha512-Wjws+uCrVQRqOoJvze4HCqkKl1AsSh95iFAeQDwnyfxM09divCBSXlDR1uTvyUP3Grzpn4Ru8GeCxYPM8vkCQg==", "dependencies": { - "argparse": "^1.0.7", - "entities": "~2.0.0", - "linkify-it": "^2.0.0", + "argparse": "^2.0.1", + "entities": "~2.1.0", + "linkify-it": "^3.0.1", "mdurl": "^1.0.1", "uc.micro": "^1.0.5" }, @@ -3634,6 +3659,24 @@ "markdown-it": "bin/markdown-it.js" } }, + "node_modules/markdown-it-link-attributes": { + "version": "3.0.0", + "resolved": "https://registry.npmjs.org/markdown-it-link-attributes/-/markdown-it-link-attributes-3.0.0.tgz", + "integrity": "sha512-B34ySxVeo6MuEGSPCWyIYryuXINOvngNZL87Mp7YYfKIf6DcD837+lXA8mo6EBbauKsnGz22ZH0zsbOiQRWTNg==" + }, + "node_modules/markdown-it/node_modules/argparse": { + "version": "2.0.1", + "resolved": "https://registry.npmjs.org/argparse/-/argparse-2.0.1.tgz", + "integrity": "sha512-8+9WqebbFzpX9OR+Wa6O29asIogeRMzcGtAINdpMHHyAg10f05aSFVBbcEqGf/PXw1EjAZ+q2/bEBg3DvurK3Q==" + }, + "node_modules/markdown-it/node_modules/entities": { + "version": "2.1.0", + "resolved": "https://registry.npmjs.org/entities/-/entities-2.1.0.tgz", + "integrity": "sha512-hCx1oky9PFrJ611mf0ifBLBRW8lUUVRlFolb5gWRfIELabBlbp9xZvrqZLZAs+NxFnbfQoeGd8wDkygjg7U85w==", + "funding": { + "url": "https://github.com/fb55/entities?sponsor=1" + } + }, "node_modules/maximatch": { "version": "0.1.0", "resolved": "https://registry.npmjs.org/maximatch/-/maximatch-0.1.0.tgz", @@ -6040,6 +6083,28 @@ "slugify": "^1.4.7", "time-require": "^0.1.2", "valid-url": "^1.0.9" + }, + "dependencies": { + "linkify-it": { + "version": "2.2.0", + "resolved": "https://registry.npmjs.org/linkify-it/-/linkify-it-2.2.0.tgz", + "integrity": "sha512-GnAl/knGn+i1U/wjBz3akz2stz+HrHLsxMwHQGofCDfPvlf+gDKN58UtfmUquTY4/MXeE2x7k19KQmeoZi94Iw==", + "requires": { + "uc.micro": "^1.0.1" + } + }, + "markdown-it": { + "version": "10.0.0", + "resolved": "https://registry.npmjs.org/markdown-it/-/markdown-it-10.0.0.tgz", + "integrity": "sha512-YWOP1j7UbDNz+TumYP1kpwnP0aEa711cJjrAQrzd0UXlbJfc5aAq0F/PZHjiioqDC1NKgvIMX+o+9Bk7yuM2dg==", + "requires": { + "argparse": "^1.0.7", + "entities": "~2.0.0", + "linkify-it": "^2.0.0", + "mdurl": "^1.0.1", + "uc.micro": "^1.0.5" + } + } } }, "@babel/code-frame": { @@ -8565,9 +8630,9 @@ "integrity": "sha1-HADHQ7QzzQpOgHWPe2SldEDZ/wA=" }, "linkify-it": { - "version": "2.2.0", - "resolved": "https://registry.npmjs.org/linkify-it/-/linkify-it-2.2.0.tgz", - "integrity": "sha512-GnAl/knGn+i1U/wjBz3akz2stz+HrHLsxMwHQGofCDfPvlf+gDKN58UtfmUquTY4/MXeE2x7k19KQmeoZi94Iw==", + "version": "3.0.3", + "resolved": "https://registry.npmjs.org/linkify-it/-/linkify-it-3.0.3.tgz", + "integrity": "sha512-ynTsyrFSdE5oZ/O9GEf00kPngmOfVwazR5GKDq6EYfhlpFug3J2zybX56a2PRRpc9P+FuSoGNAwjlbDs9jJBPQ==", "requires": { "uc.micro": "^1.0.1" } @@ -8713,17 +8778,34 @@ "integrity": "sha1-wyq9C9ZSXZsFFkW7TyasXcmKDb8=" }, "markdown-it": { - "version": "10.0.0", - "resolved": "https://registry.npmjs.org/markdown-it/-/markdown-it-10.0.0.tgz", - "integrity": "sha512-YWOP1j7UbDNz+TumYP1kpwnP0aEa711cJjrAQrzd0UXlbJfc5aAq0F/PZHjiioqDC1NKgvIMX+o+9Bk7yuM2dg==", + "version": "12.2.0", + "resolved": "https://registry.npmjs.org/markdown-it/-/markdown-it-12.2.0.tgz", + "integrity": "sha512-Wjws+uCrVQRqOoJvze4HCqkKl1AsSh95iFAeQDwnyfxM09divCBSXlDR1uTvyUP3Grzpn4Ru8GeCxYPM8vkCQg==", "requires": { - "argparse": "^1.0.7", - "entities": "~2.0.0", - "linkify-it": "^2.0.0", + "argparse": "^2.0.1", + "entities": "~2.1.0", + "linkify-it": "^3.0.1", "mdurl": "^1.0.1", "uc.micro": "^1.0.5" + }, + "dependencies": { + "argparse": { + "version": "2.0.1", + "resolved": "https://registry.npmjs.org/argparse/-/argparse-2.0.1.tgz", + "integrity": "sha512-8+9WqebbFzpX9OR+Wa6O29asIogeRMzcGtAINdpMHHyAg10f05aSFVBbcEqGf/PXw1EjAZ+q2/bEBg3DvurK3Q==" + }, + "entities": { + "version": "2.1.0", + "resolved": "https://registry.npmjs.org/entities/-/entities-2.1.0.tgz", + "integrity": "sha512-hCx1oky9PFrJ611mf0ifBLBRW8lUUVRlFolb5gWRfIELabBlbp9xZvrqZLZAs+NxFnbfQoeGd8wDkygjg7U85w==" + } } }, + "markdown-it-link-attributes": { + "version": "3.0.0", + "resolved": "https://registry.npmjs.org/markdown-it-link-attributes/-/markdown-it-link-attributes-3.0.0.tgz", + "integrity": "sha512-B34ySxVeo6MuEGSPCWyIYryuXINOvngNZL87Mp7YYfKIf6DcD837+lXA8mo6EBbauKsnGz22ZH0zsbOiQRWTNg==" + }, "maximatch": { "version": "0.1.0", "resolved": "https://registry.npmjs.org/maximatch/-/maximatch-0.1.0.tgz", diff --git a/package.json b/package.json index d8b8955..52451d3 100644 --- a/package.json +++ b/package.json @@ -24,6 +24,8 @@ "eslint-plugin-unicorn": "^33.0.1", "esm": "^3.2.25", "htm": "^3.0.4", + "markdown-it": "^12.2.0", + "markdown-it-link-attributes": "^3.0.0", "preact": "^10.5.13", "preact-render-to-string": "^5.1.19", "prettier": "2.3.2", diff --git a/src/js/components/Markdown.js b/src/js/components/Markdown.js index 60c2d37..eaf9f87 100644 --- a/src/js/components/Markdown.js +++ b/src/js/components/Markdown.js @@ -1,5 +1,7 @@ import { html } from 'htm/preact' +import md from '../utils/markdownIt' + export default ({ content }) => html` -
+
` diff --git a/src/js/utils/markdownIt.js b/src/js/utils/markdownIt.js new file mode 100644 index 0000000..ff5f1a4 --- /dev/null +++ b/src/js/utils/markdownIt.js @@ -0,0 +1,15 @@ +import markdownIt from 'markdown-it' +import markdownItLinkAttributes from 'markdown-it-link-attributes' + +export default () => { + const md = markdownIt({ html: true }) + + md.use(markdownItLinkAttributes, { + attrs: { + class: + 'underline text-red(hover:600 active:700) focus-visible:(outline-none ring-2 ring-blue-300 border-transparent)', + }, + }) + + return md +} From 083ce60f1d788ead042bd914aff8012a646b54ac Mon Sep 17 00:00:00 2001 From: Steellow Date: Mon, 25 Oct 2021 18:58:44 +0300 Subject: [PATCH 05/12] Fix md-it --- src/js/components/Markdown.js | 4 +--- src/js/utils/markdownIt.js | 18 ++++++------------ 2 files changed, 7 insertions(+), 15 deletions(-) diff --git a/src/js/components/Markdown.js b/src/js/components/Markdown.js index eaf9f87..60c2d37 100644 --- a/src/js/components/Markdown.js +++ b/src/js/components/Markdown.js @@ -1,7 +1,5 @@ import { html } from 'htm/preact' -import md from '../utils/markdownIt' - export default ({ content }) => html` -
+
` diff --git a/src/js/utils/markdownIt.js b/src/js/utils/markdownIt.js index ff5f1a4..d5d50ed 100644 --- a/src/js/utils/markdownIt.js +++ b/src/js/utils/markdownIt.js @@ -1,15 +1,9 @@ import markdownIt from 'markdown-it' import markdownItLinkAttributes from 'markdown-it-link-attributes' -export default () => { - const md = markdownIt({ html: true }) - - md.use(markdownItLinkAttributes, { - attrs: { - class: - 'underline text-red(hover:600 active:700) focus-visible:(outline-none ring-2 ring-blue-300 border-transparent)', - }, - }) - - return md -} +export default markdownIt({ html: true }).use(markdownItLinkAttributes, { + attrs: { + class: + 'underline text-red(hover:600 active:700) focus-visible:(outline-none ring-2 ring-blue-300 border-transparent)', + }, +}) From 31629ea35033cb2238911280b96bb15d12f9f6fd Mon Sep 17 00:00:00 2001 From: Steellow Date: Mon, 25 Oct 2021 19:10:52 +0300 Subject: [PATCH 06/12] Export linkClasses const --- src/js/components/Link.js | 8 ++------ src/js/utils/const.js | 5 +++++ src/js/utils/markdownIt.js | 4 ++-- 3 files changed, 9 insertions(+), 8 deletions(-) create mode 100644 src/js/utils/const.js diff --git a/src/js/components/Link.js b/src/js/components/Link.js index 1113759..45d3584 100644 --- a/src/js/components/Link.js +++ b/src/js/components/Link.js @@ -1,6 +1,7 @@ import { ExternalLinkIcon } from '@heroicons/react/solid' import { html } from 'htm/preact' import { apply, tw } from 'twind' +import { linkClasses } from '../utils/const' export default ({ children, @@ -10,12 +11,7 @@ export default ({ ...rest }) => html` Date: Mon, 25 Oct 2021 19:12:31 +0300 Subject: [PATCH 07/12] Remove autosort eslint rule --- .eslintrc.js | 4 +--- package-lock.json | 15 --------------- package.json | 1 - 3 files changed, 1 insertion(+), 19 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index f553a7d..6631236 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -25,7 +25,7 @@ module.exports = { ecmaVersion: 2021, sourceType: 'module', }, - plugins: ['simple-import-sort', 'sonarjs', 'unicorn'], + plugins: ['sonarjs', 'unicorn'], rules: { /* BUILT-IN RULES */ @@ -56,8 +56,6 @@ module.exports = { 'eslint-comments/no-unused-disable': 'error', - 'simple-import-sort/imports': 'error', - /* UNICORN * * An opinionated selection of the Unicorn rules. diff --git a/package-lock.json b/package-lock.json index 4c2f981..e72db67 100644 --- a/package-lock.json +++ b/package-lock.json @@ -16,7 +16,6 @@ "eslint-config-prettier": "^8.3.0", "eslint-plugin-eslint-comments": "^3.2.0", "eslint-plugin-import": "^2.22.1", - "eslint-plugin-simple-import-sort": "^7.0.0", "eslint-plugin-sonarjs": "^0.8.0-125", "eslint-plugin-unicorn": "^33.0.1", "esm": "^3.2.25", @@ -2119,14 +2118,6 @@ "node": ">=4" } }, - "node_modules/eslint-plugin-simple-import-sort": { - "version": "7.0.0", - "resolved": "https://registry.npmjs.org/eslint-plugin-simple-import-sort/-/eslint-plugin-simple-import-sort-7.0.0.tgz", - "integrity": "sha512-U3vEDB5zhYPNfxT5TYR7u01dboFZp+HNpnGhkDB2g/2E4wZ/g1Q9Ton8UwCLfRV9yAKyYqDh62oHOamvkFxsvw==", - "peerDependencies": { - "eslint": ">=5.0.0" - } - }, "node_modules/eslint-plugin-sonarjs": { "version": "0.8.0-125", "resolved": "https://registry.npmjs.org/eslint-plugin-sonarjs/-/eslint-plugin-sonarjs-0.8.0-125.tgz", @@ -7666,12 +7657,6 @@ } } }, - "eslint-plugin-simple-import-sort": { - "version": "7.0.0", - "resolved": "https://registry.npmjs.org/eslint-plugin-simple-import-sort/-/eslint-plugin-simple-import-sort-7.0.0.tgz", - "integrity": "sha512-U3vEDB5zhYPNfxT5TYR7u01dboFZp+HNpnGhkDB2g/2E4wZ/g1Q9Ton8UwCLfRV9yAKyYqDh62oHOamvkFxsvw==", - "requires": {} - }, "eslint-plugin-sonarjs": { "version": "0.8.0-125", "resolved": "https://registry.npmjs.org/eslint-plugin-sonarjs/-/eslint-plugin-sonarjs-0.8.0-125.tgz", diff --git a/package.json b/package.json index 52451d3..8912def 100644 --- a/package.json +++ b/package.json @@ -19,7 +19,6 @@ "eslint-config-prettier": "^8.3.0", "eslint-plugin-eslint-comments": "^3.2.0", "eslint-plugin-import": "^2.22.1", - "eslint-plugin-simple-import-sort": "^7.0.0", "eslint-plugin-sonarjs": "^0.8.0-125", "eslint-plugin-unicorn": "^33.0.1", "esm": "^3.2.25", From ddf3814bed4df7b202a018554366703d086bd2d5 Mon Sep 17 00:00:00 2001 From: Steellow Date: Mon, 25 Oct 2021 19:17:31 +0300 Subject: [PATCH 08/12] Add ring offset to focus style --- src/js/utils/const.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/utils/const.js b/src/js/utils/const.js index 34cb808..3ea0ee1 100644 --- a/src/js/utils/const.js +++ b/src/js/utils/const.js @@ -2,4 +2,4 @@ /* eslint-disable import/prefer-default-export */ export const linkClasses = - 'underline text-red(hover:600 active:700) focus-visible:(outline-none ring-2 ring-blue-300)' + 'underline text-red(hover:600 active:700) focus-visible:(outline-none ring(2 blue-300 offset-2))' From 16120039cf3b1b02ac084d314737b61bcfedcd10 Mon Sep 17 00:00:00 2001 From: Steellow Date: Tue, 26 Oct 2021 16:48:17 +0300 Subject: [PATCH 09/12] Reinstall simple-import-sort --- .eslintrc.js | 4 +++- package-lock.json | 19 ++++++++++++++++++- package.json | 3 ++- 3 files changed, 23 insertions(+), 3 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 6631236..f553a7d 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -25,7 +25,7 @@ module.exports = { ecmaVersion: 2021, sourceType: 'module', }, - plugins: ['sonarjs', 'unicorn'], + plugins: ['simple-import-sort', 'sonarjs', 'unicorn'], rules: { /* BUILT-IN RULES */ @@ -56,6 +56,8 @@ module.exports = { 'eslint-comments/no-unused-disable': 'error', + 'simple-import-sort/imports': 'error', + /* UNICORN * * An opinionated selection of the Unicorn rules. diff --git a/package-lock.json b/package-lock.json index e72db67..0159190 100644 --- a/package-lock.json +++ b/package-lock.json @@ -29,7 +29,8 @@ "twind": "^0.16.16" }, "devDependencies": { - "@types/eslint": "^7.2.13" + "@types/eslint": "^7.2.13", + "eslint-plugin-simple-import-sort": "^7.0.0" }, "engines": { "node": ">=14.0.0", @@ -2118,6 +2119,15 @@ "node": ">=4" } }, + "node_modules/eslint-plugin-simple-import-sort": { + "version": "7.0.0", + "resolved": "https://registry.npmjs.org/eslint-plugin-simple-import-sort/-/eslint-plugin-simple-import-sort-7.0.0.tgz", + "integrity": "sha512-U3vEDB5zhYPNfxT5TYR7u01dboFZp+HNpnGhkDB2g/2E4wZ/g1Q9Ton8UwCLfRV9yAKyYqDh62oHOamvkFxsvw==", + "dev": true, + "peerDependencies": { + "eslint": ">=5.0.0" + } + }, "node_modules/eslint-plugin-sonarjs": { "version": "0.8.0-125", "resolved": "https://registry.npmjs.org/eslint-plugin-sonarjs/-/eslint-plugin-sonarjs-0.8.0-125.tgz", @@ -7657,6 +7667,13 @@ } } }, + "eslint-plugin-simple-import-sort": { + "version": "7.0.0", + "resolved": "https://registry.npmjs.org/eslint-plugin-simple-import-sort/-/eslint-plugin-simple-import-sort-7.0.0.tgz", + "integrity": "sha512-U3vEDB5zhYPNfxT5TYR7u01dboFZp+HNpnGhkDB2g/2E4wZ/g1Q9Ton8UwCLfRV9yAKyYqDh62oHOamvkFxsvw==", + "dev": true, + "requires": {} + }, "eslint-plugin-sonarjs": { "version": "0.8.0-125", "resolved": "https://registry.npmjs.org/eslint-plugin-sonarjs/-/eslint-plugin-sonarjs-0.8.0-125.tgz", diff --git a/package.json b/package.json index 8912def..df4816a 100644 --- a/package.json +++ b/package.json @@ -32,7 +32,8 @@ "twind": "^0.16.16" }, "devDependencies": { - "@types/eslint": "^7.2.13" + "@types/eslint": "^7.2.13", + "eslint-plugin-simple-import-sort": "^7.0.0" }, "engines": { "node": ">=14.0.0", From b13c4206462eb46b17c875391a01b41bb529a0a4 Mon Sep 17 00:00:00 2001 From: Steellow Date: Tue, 26 Oct 2021 16:54:00 +0300 Subject: [PATCH 10/12] Add comment about eslint autofix --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index 738d5d1..3272e51 100644 --- a/README.md +++ b/README.md @@ -21,6 +21,10 @@ Also, in VS Code: 2. Choose _"Extensions: Show Recommended Extensions"_ 3. Install the recommended extensions +### Other tips + +- [Run 'ESLint: Fix all auto-fixable Problems' on save](https://www.digitalocean.com/community/tutorials/workflow-auto-eslinting#step-4-%E2%80%93-adding-code-actions-on-save) + ## Building for production 1. `npm install` From 8b2905a8da79b0441b2a189c29f4140b255e42b3 Mon Sep 17 00:00:00 2001 From: Steellow Date: Tue, 26 Oct 2021 16:55:39 +0300 Subject: [PATCH 11/12] Change simple-import-sort rule from error to warn --- .eslintrc.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.eslintrc.js b/.eslintrc.js index f553a7d..c6b30dd 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -56,7 +56,7 @@ module.exports = { 'eslint-comments/no-unused-disable': 'error', - 'simple-import-sort/imports': 'error', + 'simple-import-sort/imports': 'warn', /* UNICORN * From 2b2c335228b902541f0c8a8bb57f2c25db6f617d Mon Sep 17 00:00:00 2001 From: Steellow Date: Tue, 26 Oct 2021 17:10:51 +0300 Subject: [PATCH 12/12] =?UTF-8?q?no-unused-vars:=20error=20=E2=86=92=20war?= =?UTF-8?q?n?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .eslintrc.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.eslintrc.js b/.eslintrc.js index c6b30dd..6a2a062 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -40,6 +40,8 @@ module.exports = { // because sometimes it's clearer than template strings 'prefer-template': 'off', + 'no-unused-vars': 'warn', + /* PRETTIER * * These Airbnb rules need to be re-defined