✨ tags table change button styles #2119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TalyaNaima
requested review from
ibolton336,
sjd78 and
rszwajko
as code owners
TalyaNaima
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2119 +/- ##
==========================================
+ Coverage 39.20% 41.98% +2.78%
==========================================
Files 146 175 +29
Lines 4857 5630 +773
Branches 1164 1394 +230
==========================================
+ Hits 1904 2364 +460
- Misses 2939 3250 +311
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mguetta1
changed the title
|
opening after running updated tests |
rszwajko
requested changes
Oct 29, 2024
Signed-off-by: TalyaNeima <[email protected]>
TalyaNaima
force-pushed
the
talya-t-table
branch
from
68035c1
to
ddcfc33
Compare
|
mguetta1, noticed that the rows of tags style has changed, |
|
@mguetta1 @TalyaNaima after #2145 this will be more on the same line - the difference will be still there but I think it's a feature not a bug :) |
|
Closed and reopened after updating the description with UI tests PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changing the style of the edit & delete buttons in tags table (including the tags category)
Part of #1318
before the changes (using patternFly-4):
after the changes (using patternFly-5):
UI tests PR: 1237