Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor useServerTasks() hook to allow reuse in both tasks page and tasks drawer #1995

Closed
rszwajko opened this issue Jul 3, 2024 · 5 comments
Closed

Refactor useServerTasks() hook to allow reuse in both tasks page and tasks drawer #1995

rszwajko opened this issue Jul 3, 2024 · 5 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
Next

Comments

@rszwajko
Copy link
Collaborator

rszwajko commented Jul 3, 2024

Remaining part of : #1969
The proposal defined in this comment.
@rszwajko rszwajko added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 3, 2024
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 3, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Jul 3, 2024
@sjd78 sjd78 added this to the Next milestone Jul 3, 2024
@sjd78
Copy link
Member

sjd78 commented Jul 3, 2024 •
edited
Loading

/priority normal
/triage accepted

@konveyor-ci-bot konveyor-ci-bot bot added priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jul 3, 2024
@sjd78
Copy link
Member

sjd78 commented Jul 11, 2024

@rszwajko -- I think you may have already handled this in #2004

@rszwajko
Copy link
Collaborator Author

@rszwajko -- I think you may have already handled this in #2004

Re-using task actions is a parallel task. My understanding is that under this issue we want to achieve sth similar to DecoratedApplication

@rszwajko
Copy link
Collaborator Author

Task drawer switched to using the infinite scroller pattern which requires a dedicated data source : useInfinteServerTasks().
Therefore using a common hook is no longer possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
Next
Development

No branches or pull requests
2 participants
@sjd78 @rszwajko