Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLASS and ENUM location in java provider to match against class declarations and enums #761

Open
jmle opened this issue Jan 15, 2025 · 3 comments
Open

Add CLASS and ENUM location in java provider to match against class declarations and enums #761

jmle opened this issue Jan 15, 2025 · 3 comments
Assignees
@jmle
Labels
needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@jmle
Copy link
Contributor

jmle commented Jan 15, 2025 •
edited
Loading

Currently we have the TYPE location, which matches against all types (i.e. classes, interfaces, enum and annotation types). It would be ideal to be able to match exclusively against class declarations, for instance to be able to look for annotated classes and not other types.

Also, implement the ENUM location, which is currently unimplemented.
@jmle jmle self-assigned this Jan 15, 2025
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Jan 15, 2025
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 15, 2025
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jan 15, 2025
@jmle jmle changed the title Add CLASS location in java provider to match against class declarations Add CLASS and ENUM location in java provider to match against class declarations and enums Jan 15, 2025
@jmle jmle moved this from 🆕 New to 🏗 In progress in Planning Jan 15, 2025
@shawn-hurley
Copy link
Contributor

Knowing what we know now about the types from the search engine, this may be possible but you may have to write a lot of code I think to get that. Just a heads up.

@jmle
Copy link
Contributor Author

jmle commented Jan 16, 2025

Knowing what we know now about the types from the search engine, this may be possible but you may have to write a lot of code I think to get that. Just a heads up.

@shawn-hurley theoretically there is a way to look for classes only, which is more specific than TYPE. I'm working on it to see how it goes

This was referenced Jan 20, 2025
Merged
Merged
jmle added a commit that referenced this issue Jan 20, 2025
@jmle
✨ Add CLASS location in java provider (#763)
77991ef 
Adds ability to send CLASS declaration locations to the java provider.

- Issue:
#761 (comment)

Bundle PR: 120

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmle jmle

Labels
needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Planning
Status: 🏗 In progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shawn-hurley @jmle