Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with konnected-esphome #3

Open
heythisisnate opened this issue Mar 11, 2024 · 1 comment
Open

Merge with konnected-esphome #3

heythisisnate opened this issue Mar 11, 2024 · 1 comment

Comments

@heythisisnate
Copy link
Contributor

I think this shouldn't need to be a separate repo. It really just needs to be a /components folder in konnected-io/konnected-esphome.

The issue of licensing comes up, but I think ESPHome handles this well using multiple licenses: https://github.com/esphome/esphome/blob/dev/LICENSE
The YAML should be MIT licensed and C code should follow the GPL license, following ESPHome's example.

cc @h2zero any thoughts?

@h2zero
Copy link
Collaborator

h2zero commented Mar 12, 2024

Sounds good to me, I just kept it separate while testing/developing so it would t conflict with the other repos changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants