Option KokkosTools_REUSE_KOKKOS_COMPILER does not work

[maartenarnst]

Because the call to project can be expected to already set CMAKE_CXX_COMPILER

• kokkos-tools/CMakeLists.txt

  Line 3 in a9453b2

  project(KokkosTools CXX)

the option KokkosTools_REUSE_KOKKOS_COMPILER can no longer change CMAKE_CXX_COMPILER

• kokkos-tools/CMakeLists.txt

  Lines 65 to 68 in a9453b2

  	if(KokkosTools_REUSE_KOKKOS_COMPILER)
  	set(CMAKE_CXX_COMPILER "${Kokkos_CXX_COMPILER}" CACHE STRING "C++ Compiler")
  	set(CMAKE_CXX_STANDARD "${CMAKE_CXX_STANDARD_DEFAULT}" CACHE STRING "C++ Standard: 98, 11, 14, 17, 20 or 23")
  	endif()

so the option KokkosTools_REUSE_KOKKOS_COMPILER can be expected not to work.

Ways forward could be

• remove the option KokkosTools_REUSE_KOKKOS_COMPILER
• use FORCE in the set command

Using FORCE would indeed "reuse" the compiler, but it may not be a good solution because some flags may have been set already in the toolchain for the compiler that is now being overridden with force.

Note that the CMake documentation says that CMAKE_CXX_COMPILER may be set only once:

• https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_COMPILER.html

Joint work with @romintomasetti.