Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kokkos version check #32

Closed
lucbv opened this issue Jan 23, 2024 · 3 comments · Fixed by #47
Closed

Kokkos version check #32

lucbv opened this issue Jan 23, 2024 · 3 comments · Fixed by #47
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@lucbv
Copy link

lucbv commented Jan 23, 2024

Hi all another issue appears to be the lack of check on the Kokkos Version being used when building against a pre-installed Kokkos library.
I am suspecting that for the time being it works with 4.2.0 and maybe up to 4.0.0 but likely not against anything older than that?
It would be good to add something in CMakeLists.txt to warn users if they attempt to install against an unsupported version.
Also updating the documentation to reflect what is actually supported would be great!

@yasahi-hpc
Copy link
Collaborator

Thank you for the comments!
I was not aware of this point, but clearly it is important.
I will add warnings that the insulation against older than version 4.0.0 is not supported.

Documentation will certainly be improved before release!

@yasahi-hpc yasahi-hpc added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 24, 2024
@cedricchevalier19
Copy link
Member

You can put a minimal version with find_package.

@yasahi-hpc
Copy link
Collaborator

In addition, I would improve the Versioning in CMake which is added in (#41).

This was referenced Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants