Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support searching for multiple tags #33

Closed
Tracked by #26
Kabuda-czh opened this issue Mar 22, 2023 · 6 comments
Closed
Tracked by #26

Feature: Support searching for multiple tags #33

Kabuda-czh opened this issue Mar 22, 2023 · 6 comments
Labels
🐛 bug Something isn't working ⚙️ core
Milestone

Comments

@Kabuda-czh
Copy link
Member

Sources

Danbooru, Gelbooru, Konachan.com (NSFW), Konachan.net (SFW), Lolibooru, Lolicon, Pixiv, Safebooru, Yande.re

Describe the problem related to the feature request

can't search multiple tags
booru blue_archive blue_eye
only search blue_archive

Describe the solution you'd like

Suggestion: Make the following changes in the core file
core#L123

ctx
    .command('booru <rest...>')
    .option('count', '-c <count:number>', { type: count, fallback: 1 })
    .option('label', '-l <label:string>')
    .action(async ({ session, options }, ...rest) => {
      const query = rest?.join(' ')?.trim() ?? ''

Describe alternatives you've considered

No response

Additional context

No response

@MaikoTan MaikoTan added 🐛 bug Something isn't working ⚙️ core labels Mar 22, 2023
@MaikoTan MaikoTan added this to the v1.0.2 milestone Mar 22, 2023
@MaikoTan
Copy link
Member

Well, it actually bug. generally we should accept multiple tags.

@MaikoTan
Copy link
Member

And by the meantime, I want to introduce the tag represented just like WaifuDiffusion uses, which is comma separated, no underline: 1girl, black eyes, long hair rather than 1girl black_eyes long_hair. What do you think?

@Kabuda-czh
Copy link
Member Author

And by the meantime, I want to introduce the tag represented just like WaifuDiffusion uses, which is comma separated, no underline: 1girl, black eyes, long hair rather than 1girl black_eyes long_hair. What do you think?

Looks good, but some image sources need to be processed additionally with '_'

@MaikoTan
Copy link
Member

Looks good, but some image sources need to be processed additionally with '_'

Par exemples ?

@Kabuda-czh
Copy link
Member Author

Looks good, but some image sources need to be processed additionally with '_'

Par exemples ?

Sorry, I think I forgot about the additional processing for tags.

@MaikoTan
Copy link
Member

This should be fixed by #36 , @Kabuda-czh please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ⚙️ core
Projects
None yet
Development

No branches or pull requests

2 participants