Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple IPTV doesn't read the tvg-name tag now #913

Open
goldengate2121 opened this issue Oct 15, 2024 · 15 comments
Open

Simple IPTV doesn't read the tvg-name tag now #913

goldengate2121 opened this issue Oct 15, 2024 · 15 comments

Comments

@goldengate2121
Copy link

In the past SIPTV would read the tvg-name if the tvg-id was left blank and then display the proper guide. In the latest version 22.2.2 it no longer uses the tvg-name if the tvg-id is left blank so you are left without guide data.

https://paste.kodi.tv/zecuvepuhi.kodi

@phunkyfish
Copy link
Member

phunkyfish commented Oct 16, 2024

Can you provide a test M3U and xmltv file that demonstrates this and I’ll take a look?

In your log it simply shows that no EPG channels were found so difficult to deduce what is going wrong.

@goldengate2121
Copy link
Author

I put them in the same paste bin

https://paste.kodi.tv/pexaseqewu

@phunkyfish
Copy link
Member

phunkyfish commented Oct 16, 2024

The error is in your Xmltv file.

For tvg-name to match it must equal the display name of the channel. But in your example file there is what looked like a foreign character instead of P.

IMG_7823

Note that this code has not changed in a very long time. So it was extremely unlikely the addon was at fault.

@goldengate2121
Copy link
Author

I had other channels with English characters that I had the same issue. I rushed to get you the file so I made a mistake. I will get an updated one this weekend.

@phunkyfish
Copy link
Member

I had other channels with English characters that I had the same issue. I rushed to get you the file so I made a mistake. I will get an updated one this weekend.

Ok, no problem.

@phunkyfish
Copy link
Member

I updated the incorrect character in your XML and it worked for me!

Screenshot 2024-10-16 at 19 18 19

@goldengate2121
Copy link
Author

Okay, I will reconfirm this weekend and see where I went wrong and report back and close out the ticket.

@goldengate2121
Copy link
Author

I didn't realize that the Display name and the tvg-name must be equal. It wasn't this way in the past.

@phunkyfish
Copy link
Member

It has always been like this. That code has not changed in many years. The preference order for matching channels to EPG is as follows:

1 - Match on tvg-id
2 - Match on display-name and tvg-name
3 - Match on display-name and channel name

The first one of the above to match will cause that EPG to be chosen.

@goldengate2121
Copy link
Author

goldengate2121 commented Oct 19, 2024

Here is the xml and m3u

https://paste.kodi.tv/ufugukasaj

Screenshot in Kodi 21 (please note, I edited the theme to display weather and date) EPG SIPTV ver 21.9.8
screenshot00001

Screenshot Piers no EPG same xml and m3u ver 22.2.2
screenshot00000

@phunkyfish
Copy link
Member

Ok, very strange. I can see from the files that tvg-name and display-name do not match. So no EPG displayed is what I would expect.

I’m stumped as to why v21 shows data as the code in both branches is identical.

@goldengate2121
Copy link
Author

The changelog says it looks for tvg-id then tvg-name and then channel name.

I assume this is done in the playlisterloader.cpp and .h files. I diff'ed the playlisterloader.h between 22.2.2 and 21.7.2 and there are a few slight differences but I don't know C well enough.

@phunkyfish
Copy link
Member

phunkyfish commented Oct 20, 2024

Which version is the changelog entry you are referring to?

playlistloader is where we read tvg-id and tvg-name.

EPG.cpp is where we lookup an EPG and match against tvg-id, tvg-name and channel name

ChannelEpg* Epg::FindEpgForChannel(const Channel& channel) const

@goldengate2121
Copy link
Author

In the changelog it is at v4.5.0 or line 481.

Okay on the code. I am not good with C.

@phunkyfish
Copy link
Member

V4.50 is 5 releases ago, so about 6/7 years. so as I said, the code has been that way for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants