Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden errors #24

Open
IceflowRE opened this issue Oct 18, 2023 · 1 comment
Open

Hidden errors #24

IceflowRE opened this issue Oct 18, 2023 · 1 comment

Comments

@IceflowRE
Copy link
Contributor

These errors are hidden and unknown to the caller, despite they could be pretty important.
The only workaround is to copy the code which makes the library pretty useless in this case.

t, err := termFromJSON(b[v])

term, err := termFromJSON(v)

@boutros
Copy link
Member

boutros commented Oct 19, 2023

Good point.
On the other hand, it's quite unlikely that a SPARQL engine manages to serialize RDF nodes wrong... Have you experienced this in practice?

I'm not working much with this package now, so I probably won't work on this myself. I'd like to not change the API at this point, so if you want it to return an error I'd prefer a new method..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants