You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 22, 2023. It is now read-only.
'NotificationCompose' extends 'Compose' and calls its own 'setUpReplyText' method in onCreate.
However, I find that 'finish' method can be called in 'setUpReplyText', which can skip the onStop method according to Android documents. Meanwhile, in 'Compose', GoogleApiClient is required in onCreate while released in onStop, there may be a case that GoogleApiClient is never released when 'finish' is called, isn't it?
Maybe a better solution is to override the 'finish' method and release the GoogleApiClient in it if not.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
'NotificationCompose' extends 'Compose' and calls its own 'setUpReplyText' method in onCreate.
However, I find that 'finish' method can be called in 'setUpReplyText', which can skip the onStop method according to Android documents. Meanwhile, in 'Compose', GoogleApiClient is required in onCreate while released in onStop, there may be a case that GoogleApiClient is never released when 'finish' is called, isn't it?
Maybe a better solution is to override the 'finish' method and release the GoogleApiClient in it if not.
The text was updated successfully, but these errors were encountered: