Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] WriteToFile / Magicksave async #110

Open
lofcz opened this issue Jan 2, 2021 · 1 comment
Open

[question] WriteToFile / Magicksave async #110

lofcz opened this issue Jan 2, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@lofcz
Copy link

lofcz commented Jan 2, 2021

From my current understanding, while calling one of these methods to save an image, the current thread hangs instead of doing someting useful while an image is being saved. Would it be possible to introduce async overloads of these methods?

@kleisauke kleisauke added the enhancement New feature or request label Jan 28, 2021
@kleisauke
Copy link
Owner

Indeed, the WriteTo{File,Buffer,Target,Stream} and *save{Buffer,Target,Stream} operations are currently missing async overloads. As for the implementation of this, I think it only makes sense to use async for operations that will trigger a pixel loop, since most NetVips operations are instant.

Let's tag this as an enhancement. Very happy to accept a PR, if you're able.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants