Consider replacing all the "blacklisting" terminology

[sleberknight]

IntelliJ's code analysis was very adamant that we should replace the "blacklist" terminology throughout the project (its source was the "alex" style guide, which I assume is this one). This would require, at a minimum, deprecating the BlacklistingConsulFailoverStrategy and replacing it with a copy of the class with a new name, and then replacing all usages of BlacklistingConsulFailoverStrategy.

In addition, we would need to find and replace usages in fields, method names, arguments, local variables, etc. which may require more deprecation.

So, assuming we want to do this, what should the new name be?

The Google style guide suggests:

For the noun blacklist, consider using a replacement such as denylist, excludelist, or blocklist.

https://developers.google.com/style/word-list#blacklist

I prompted ChatGPT 4 "What are some alternate names for blacklist?" and it gave me a lengthy answer with 10 possibilities. I then asked it to refine using the prompt: "Can you refine this list to the "best" 5 alternatives?" Here is its answer:

Certainly! Here are the top five alternatives to the term "blacklist," selected for their clarity, neutrality, and widespread acceptance:

1. Blocklist: Widely used in tech and networking, it clearly indicates a list of entities that are blocked from access.

2. Denylist: Similar to blocklist, it's straightforward and descriptive, indicating a list of entities denied access or use.

3. Exclusion List: This term is broad and clear, indicating a list of items or entities excluded from a particular context or action.

4. Ban List: Common in online communities and gaming, it denotes a list of banned individuals or entities, and is easily understood in various contexts.

5. Disallow List: It's simple and direct, indicating a list of entities or actions that are not allowed or permitted.

These alternatives are selected for their precision in conveying the intended function of the list without relying on potentially loaded or outdated terminology.

Given the general agreement between the Google code style guide and the first three "best" arguments from ChatGPT 4, those are probably the best options.

[sleberknight]

I am closing, since it will cause a bunch of work, and is not really a huge problem.