Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual indication of last nodes of a tree #32

Open
kisst opened this issue May 20, 2020 · 5 comments
Open

Visual indication of last nodes of a tree #32

kisst opened this issue May 20, 2020 · 5 comments

Comments

@kisst
Copy link
Owner

kisst commented May 20, 2020

When a map is rendered , a visual language does not make it trivial that an item has no sub-items, so user might try to open / close them, @anttisalo any suggestions for a clear indication, which does not take a massive toll on the implementation, color or shape changes, something less taxing then a full new GUI ?

@anttisalo
Copy link

anttisalo commented May 20, 2020

Let me have look at the source and see how the expanded/collapsed states are now handled.
The current solution is IMO on the right track but needs to be more verbose not allowing the dot state to change if there are no children under it.
image

@kisst
Copy link
Owner Author

kisst commented May 20, 2020

Maybe a + and - would work, and empty if there no child, but also the no click action is a good point I was thinking only in UI, but it is function change as well.
Saying this ... I'm unsure how would we draw into the circle 🤔

@anttisalo
Copy link

The map is made using SVG. The states are inline styles and shouldn't be a problem to change to use classnames. I'll take a look when I find a free slot today

@evenicoulddoit
Copy link
Collaborator

Why not just make the border of the circle node grey?

@kisst
Copy link
Owner Author

kisst commented May 20, 2020

That works as well, fine by me, the extra is as Antti pointed out the action should be removed / modified as well, as if the user still wonder on around and click on it that would get the gray back to blue.
And I got our UX expert into the conversation as I really don't want to add User Manual, it really should be self explanatory how to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants