Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix presets containing picsum.photos links because of Storybook examples #32

Open
julrich opened this issue Oct 30, 2024 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@julrich
Copy link
Member

julrich commented Oct 30, 2024

Like this here: https://github.com/kickstartDS/ds-agency-premium/blob/main/src/components/hero/hero.schema.json#L70-L72
Referencing this: https://github.com/kickstartDS/content/blob/next/source/visual/visual.schema.json#L58

Because Storybook uses those examples to fill in unused values, those also end up in our presets for Storyblok. In turn, they get added into components like the Hero component, where they can trigger weird behavior (e.g. see: kickstartDS#5).

@julrich julrich added the bug Something isn't working label Oct 30, 2024
@julrich julrich self-assigned this Oct 30, 2024
julrich referenced this issue in kickstartDS/storyblok-starter-premium Nov 28, 2024
@julrich julrich transferred this issue from kickstartDS/storyblok-starter-premium Dec 5, 2024
@julrich julrich moved this to Ready in CMS Starter Storyblok Dec 5, 2024
@julrich julrich moved this from Ready to Backlog in CMS Starter Storyblok Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

1 participant