Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entry API shouldn't require NamedCollection #313

Open
ecton opened this issue Dec 7, 2023 · 0 comments
Open

Entry API shouldn't require NamedCollection #313

ecton opened this issue Dec 7, 2023 · 0 comments

Comments

@ecton
Copy link
Member

ecton commented Dec 7, 2023

Currently the only way to utilize the entry API is if you implement NamedCollection. This was done to make it so that the entry API can take an ID or the "name" key. We should offer a way to use an entry API via SerializedCollection that only allows the primary key.

This will cause conflicts with the NamedCollection API. I'm not sure if there's any way to unify the API without specialization, so most likely we should rename NamedCollection's entry API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant