Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vizion.analyze fails if no remote named 'origin' is specified #12

Open
thewilli opened this issue Nov 3, 2015 · 3 comments
Open

vizion.analyze fails if no remote named 'origin' is specified #12

thewilli opened this issue Nov 3, 2015 · 3 comments

Comments

@thewilli
Copy link

thewilli commented Nov 3, 2015

if running on a git repository without an origin remote specified, vizion runs into an error:

Error: Error: Command failed: /bin/sh -c cd '/path/to/repo/';LC_ALL=en_US.UTF-8 git config --get remote.origin.url

Vizion should not crash for repositories without any remote at all or with a remote named other than "origin".

@Unitech
Copy link
Member

Unitech commented Nov 4, 2015

Hello,

Thanks for reporting this issue, does it crashed PM2 too??

@thewilli
Copy link
Author

thewilli commented Nov 4, 2015

@Unitech no, but the pm2-managed app is considered as not being under source control, and no metadata of the git repository is available.

@Unitech
Copy link
Member

Unitech commented Nov 5, 2015

So returning return cb(null, null); here https://github.com/keymetrics/vizion/blob/master/lib/git.js#L20

would do the trick right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants