-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keycloak admin cli creating/updating authention executions not respecting the priority value specified #20747
Comments
Thank you for the report, @tianqiwang ! Please, could you add here a sample content of the I did a quick check on the Endpoint used above ( So, In my view, further investigation is needed to ensure how the order of priority between Authentication Flow Execution steps is handled when updating via that Endpoint. Besides that, I'd like to ask @keycloak/core Team: Any ideas about this? Thanks in advance. |
@andre-nascimento6791 I think your analysis is correct. |
@mposolda I do understand there is increase and decrease endpoints on the API. However, I still believe that For the exact same reason [1], Terraform provider for Keycloak can't also manage executions too. The only thing they can provide [2] currently is using If that has to be done by |
Due to the amount of issues reported by the community we are not able to prioritise resolving this issue at the moment. If you are affected by this issue, upvote it by adding a 👍 to the description. We would also welcome a contribution to fix the issue. |
Hi, Currently, since the creation of this issue, there is also a linked PR (#27751) which fixes this. This PR has also tests, which makes this a very valuable and "complete" PR, IMHO. 👍👍👍 So, what else is needed to drive this issue and get the PR merged? |
Agreed, this is a small change but brings the API a further step towards being able to configure keycloak straight-foward using config-as-code. |
Closes #20747 Signed-off-by: Andrejs Mivreniks <[email protected]>
Before reporting an issue
Area
admin/cli
Describe the bug
When using the Keycloak admin-cli to create/update authentication flows, it appears that the
priority
value is not being honored. When runningkcadm.sh update authentication/flows/{authenticationFlowID}/executions -f executionConfig.json
(where executionConfig.json is a json file that contains the properties of the execution, including its priority), the other properties of the authentication execution do get properly updated, but thepriority
value does not get updated.Version
19.0.3
Expected behavior
Running
kcadm.sh update authentication/flows/{authenticationFlowID}/executions -f executionConfig.json
for different executions under the same parent flow will update the executions and order them properly based on the priority specified in the json file.Actual behavior
Running
kcadm.sh update authentication/flows/{authenticationFlowID}/executions -f executionConfig.json
for different executions under the same parent flow keeps the priority in the order in which they were originally created.How to Reproduce?
Create an authentication flow with 2 authenticationExecutions as its children.
Create configuration json files for each of the executions with "priority": 1 for the authenticationExecution that was created first and "priority": 0 for the authenticationExecution that was created second.
Run
kcadm.sh update authentication/flows/{authenticationFlowID}/executions -f executionConfig.json
for both execution config files.Verify the order of the executions using the Keycloak admin console.
Anything else?
No response
The text was updated successfully, but these errors were encountered: