Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy data services and functionality #107

Closed
tmadlener opened this issue May 22, 2023 · 6 comments
Closed

Remove legacy data services and functionality #107

tmadlener opened this issue May 22, 2023 · 6 comments

Comments

@tmadlener
Copy link
Contributor

#100 Introduced several Legacy components and services that should be absorbed cleanly into the new Frame based I/O. Once all of that has been done, the legacy functionality can be removed.

@hegner
Copy link
Contributor

hegner commented Oct 13, 2023

@andresailer - anything against doing the cleanup now? We have the podio PR ready to kick out the EventStore

@tmadlener
Copy link
Contributor Author

Tagging @kjvbrt and @BrieucF here as well as I am not entirely sure what the status is for the repositories in HEP-FCC.

@andresailer
Copy link
Contributor

Can you summarize what the status would be after the cleanup? Can old files still be read, or only new files?

@tmadlener
Copy link
Contributor Author

IIRC only new files will be readable. There is #103 still open which at least started to address this. There are two things to keep in mind.

  1. Adding an automatic switch to a podio::ROOTLegacyReader is probably not to hard to implement
  2. That might not be enough because the PodioOutput/PodioLegacyDataSvc combination wrote a slightly different file format that the EventStore/podio::ROOTWriter combination did. This is the underlying issue in PodioOutput saves metadata of droped collections into the ROOT file #95 AFAIK.

Final consideration: Solving #105 might change things once more (at least on the python config side), so maybe we can try to make a few of the breaking changes in one go and then fix up things.

@kjvbrt
Copy link
Contributor

kjvbrt commented Oct 17, 2023

As far as I can tell we should be ready with the repositories under HEP-FCC (all converted to use Frame based DataService). And for large scale samples -- they are read with FCCAnalysis, so they don’t depend on k4FWCore.

One case where legacy reader in k4FWCore is needed is, that someone has local simulated samples with k4SimGeant4 and need to be able to run reconstruction.

@tmadlener
Copy link
Contributor Author

Fixed by #171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants