-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy data services and functionality #107
Comments
@andresailer - anything against doing the cleanup now? We have the podio PR ready to kick out the EventStore |
Can you summarize what the status would be after the cleanup? Can old files still be read, or only new files? |
IIRC only new files will be readable. There is #103 still open which at least started to address this. There are two things to keep in mind.
Final consideration: Solving #105 might change things once more (at least on the python config side), so maybe we can try to make a few of the breaking changes in one go and then fix up things. |
As far as I can tell we should be ready with the repositories under HEP-FCC (all converted to use Frame based DataService). And for large scale samples -- they are read with FCCAnalysis, so they don’t depend on k4FWCore. One case where legacy reader in k4FWCore is needed is, that someone has local simulated samples with k4SimGeant4 and need to be able to run reconstruction. |
Fixed by #171 |
#100 Introduced several Legacy components and services that should be absorbed cleanly into the new Frame based I/O. Once all of that has been done, the legacy functionality can be removed.
The text was updated successfully, but these errors were encountered: