-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL Submission not properly handling commas #2218
Comments
it does, it says URL, not urlS, you need to wrie extension to handly multiple urls |
So this isn't intended behavior? We have seen legitimate url submissions that contain a comma character in them, but is interpreted as two separate submissions. |
Idk, I never submitted more that one so can't speak of that |
ok now that i read your issue properly, yes we do split by comma in urls to split them by comma, not sure which char to use to split them properly as i see that yes that allows to use comma, any suggestion? sorry misread your issue initially |
no worries - can be tricky to find a good delimiting character. I'd suggest something that can't appear in normal URL, so say a space maybe? If that doesn't work for other user use case, maybe a better solution is to make multi submissions a toggle in the web GUI. Otherwise I'd use a Latin-American character but I've no idea how this would impact other users who aren't using our character set. |
Space is legit as is %20 if not encoded
El mar, 23 jul 2024, 15:52, CarsonHrusovsky ***@***.***>
escribió:
… no worries - can be tricky to find a good delimiting character. I'd
suggest something that can't appear in normal URL, so say a space maybe? If
that doesn't work for other user use case, maybe a better solution is to
make multi submissions a toggle in the web GUI.
Otherwise I'd use a Latin-American character but I've no idea how this
would impact other users who aren't using our character set.
—
Reply to this email directly, view it on GitHub
<#2218 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOFH36TMWBKHUSYS4JKORDZNZNYLAVCNFSM6AAAAABKU7PJ42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBVGMYTSNZUGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
hmm okay - maybe this a feature that isn't needed? Would be very easy to automate multiple submissions for users who need that - and by default just make only one submission at a time expected? I struggle to think of a character that a user would both expect to be a separator and also have regular access to. (␛) this character for example could be used but this isn't practical. I think the best choice is to have users who want to submit multiple URL at the same time to handle that in a script (and have a toggle in the GUI for them as well). I would be more than happy to write a script to submit multiple URL that can be kept in the /extra/ directory for manual use by users. |
About accounts on capesandbox.com
This is open source and you are getting free support so be friendly!
Prerequisites
Please answer the following questions for yourself before submitting an issue.
Issue
This is a pretty simple bug. When submitting URLs for analysis, if a url contains a comma it interprets it as two separate submissions. This may be by design for allowing multiple submissions from the same command, but it doesn't work particularly well in a production environment.
I'd recommend just handling input on submission as a string.
The text was updated successfully, but these errors were encountered: