Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprint tags #6557

Open
MilosPaunovic opened this issue Dec 23, 2024 · 8 comments
Open

Blueprint tags #6557

MilosPaunovic opened this issue Dec 23, 2024 · 8 comments
Assignees
Labels
area/frontend Needs frontend code changes bug Something isn't working

Comments

@MilosPaunovic
Copy link
Member

MilosPaunovic commented Dec 23, 2024

When the browser window is a bit smaller or the title of blueprint is long enough to push the tags to the line below, there seems to be misalignment of the tags which are left in the same line.

Do you have a propsal on how to handle this better @Nico-Kestra?

Maybe a good issue for @Piyush-r-bhaskar to tackle once the design is there, as you've already done some great work around blueprints.

image

@MilosPaunovic MilosPaunovic added bug Something isn't working area/frontend Needs frontend code changes labels Dec 23, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Dec 23, 2024
@Nico-Kestra
Copy link
Member

I suggest reducing the number of tags displayed when the resolution is smaller, especially if there are many tags. The last tag could indicate the remaining count, e.g., "+5" (if there are 5 additional tags), and hovering over it would display the other tags in a tooltip. WDYT?

Capture d’écran 2024-12-26 à 10 17 07

@MilosPaunovic
Copy link
Member Author

Hmm, not really sure this would be good idea from product perspective, maybe Anna or Ben could give their opinions on that part.

But, this does not solve the alignment issues when one title is short and another is long, we'd still have inconsistencies.

@Nico-Kestra
Copy link
Member

Capture d’écran 2024-12-26 à 11 02 16 For me, it's exactly like a table: the tag column should be aligned, regardless of whether the blueprint title is long or not.

@Ben8t
Copy link
Member

Ben8t commented Dec 30, 2024

In this case, can we move these tags below the title?

It seems that's the case for plugin icon already. Screenshot below is from Kestra Cloud which doesn't have tags in each rows for now (old version/not on develop)

Screenshot 2024-12-30 at 10 15 17

@MilosPaunovic
Copy link
Member Author

That seems absolutely okay from my perspective.

@Piyush-r-bhaskar
Copy link
Contributor

In this case, can we move these tags below the title?

It seems that's the case for plugin icon already. Screenshot below is from Kestra Cloud which doesn't have tags in each rows for now (old version/not on develop)

Screenshot 2024-12-30 at 10 15 17

Should I check and amend it now @MilosPaunovic ?

@MilosPaunovic
Copy link
Member Author

Nope @Piyush-r-bhaskar, let's wait a bit until we all agree on the design, and I'll ping you and assign this issue to you when that is completed.

Does that sound alright?

@Piyush-r-bhaskar
Copy link
Contributor

Nope @Piyush-r-bhaskar, let's wait a bit until we all agree on the design, and I'll ping you and assign this issue to you when that is completed.

Does that sound alright?

Yup Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Needs frontend code changes bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

4 participants