Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown formatting to inputs values/display name + increase allowed displayName to be more than 64 characters #6470

Open
3 tasks
anna-geller opened this issue Dec 16, 2024 · 0 comments
Assignees
Labels
area/backend Needs backend code changes area/frontend Needs frontend code changes bug Something isn't working

Comments

@anna-geller
Copy link
Member

anna-geller commented Dec 16, 2024

Describe the issue

  • BACKEND: Display name is restricted to 64 characters which seems limiting - we should remove this limit, there are no technical reasons to have that limit
Screenshots

image


  • FRONTEND: Display name doesn't have markdown rendering yet - it would be great to add it, the same way as GitHub is able to render markdown in issue titles etc.
Screenshots

image


  • FRONTEND: Input values also lack markdown formatting — this might be a bit more tricky as we use element+ for the element. If not feasible, we'll skip this part.
Screenshots

image

Context

We were planning to leverage Apps to let students submit homework assignments, and this shows some unexpected limitations of display names.

Reproducer

id: homework
namespace: zoomcamp

inputs:
  - id: first
    type: SELECT
    displayName: 1) Uncompressed file size of `yellow_tripdata_2020-12.csv`
    description: |
      1) Within the execution for `Yellow` Taxi data for the year `2020` and month `12`: what is the uncompressed file size (i.e. the output file `yellow_tripdata_2020-12.csv` of the `extract` task)?
    required: true
    values:
      - 128.3 MB
      - 134.5 MB
      - 364.7 MB
      - 692.6 MB

  - id: second
    type: SELECT
    displayName: 2) Task run state of bq_green_tripdata for yellow taxi input
    description: |
      2) What is the task run state of tasks bq_green_tripdata, bq_green_tmp_table and bq_merge_green when you run the flow with the `taxi` input set to value `yellow`?
    required: true
    values:
      - SUCCESS
      - FAILED
      - SKIPPED
      - CANCELED

  - id: third
    type: SELECT
    displayName: |
      3) How to deal with table schema in the GCP ingestion pipeline?
    required: true
    values:
      - We don't define the schema at all because this is a data lake after all
      - We let BigQuery autodetect the schema
      - Kestra automatically infers the schema from the extracted data
      - We explicitly define the schema in the tasks that create external source tables and final target tables

  - id: fourth
    type: SELECT
    displayName: |
      4) How does Kestra handles backfills in the scheduled flow?
    required: true
    values:
      - You need to define backfill properties in the flow configuration
      - You have to run CLI commands to backfill the data
      - You can run backfills directly from the UI from the Flow Triggers tab by selecting the time period
      - Kestra doesn't support backfills
  
  - id: fifth
    type: SELECT
    displayName: 5) CRON to run flow at 09:00 UTC on the first day of every month
    description: |
      5) Which of the following CRON expressions schedules a flow to run at 09:00 UTC on the first day of every month?
    required: true
    values:
      - 0 9 1 * *
      - 0 1 9 * *
      - 0 9 * * *
      - 1 9 * * *
        
  - id: sixth
    type: SELECT
    displayName: |
      6) How to set timezone to New York in a Schedule trigger?
    required: true
    values:
      - Add a `timezone` property set to `EST` in the `Schedule` trigger configuration  
      - Add a `timezone` property set to `America/New_York` in the `Schedule` trigger configuration
      - Add a `timezone` property set to `UTC-5` in the `Schedule` trigger configuration
      - Add a `location` property set to `New_York` in the `Schedule` trigger configuration

  - id: email
    type: EMAIL
    displayName: Your email
    required: true

tasks:
  - id: submission_to_gsheets
    type: io.kestra.plugin.core.log.Log
    message: homework submission {{ inputs }}

Environment

  • Kestra Version: develop
@anna-geller anna-geller added bug Something isn't working area/backend Needs backend code changes area/frontend Needs frontend code changes labels Dec 16, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend Needs backend code changes area/frontend Needs frontend code changes bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

3 participants