Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic Rewrite feature in the editor #6405

Open
anna-geller opened this issue Dec 11, 2024 · 3 comments
Open

Magic Rewrite feature in the editor #6405

anna-geller opened this issue Dec 11, 2024 · 3 comments
Labels
area/backend Needs backend code changes area/frontend Needs frontend code changes enhancement New feature or request

Comments

@anna-geller
Copy link
Member

anna-geller commented Dec 11, 2024

The user will need to hit Save after the change to confirm the changes are OK. Even later, the user can roll back to a previous revision if needed.

image

Reproducer to see deprecated features:

id: failure_alert
namespace: company.team

tasks:
  - id: send_alert
    type: io.kestra.plugin.notifications.slack.SlackExecution
    url: "{{ secret('SLACK_WEBHOOK') }}" # format: https://hooks.slack.com/services/xzy/xyz/xyz
    channel: "#general"
    executionId: "{{trigger.executionId}}"

triggers:
  - id: failed_prod_workflows
    type: io.kestra.plugin.core.trigger.Flow
    conditions:
      - type: io.kestra.plugin.core.condition.ExecutionStatusCondition
        in:
          - FAILED
          - WARNING
      - type: io.kestra.plugin.core.condition.ExecutionNamespaceCondition
        namespace: prod
        prefix: true
@anna-geller anna-geller added area/backend Needs backend code changes enhancement New feature or request area/frontend Needs frontend code changes labels Dec 11, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Dec 11, 2024
@Ben8t
Copy link
Member

Ben8t commented Dec 16, 2024

Optional: in addition to clickable rewrite option in flow editor, add a toggle in the settings so users can set this "rewrite" as an automation

@anna-geller
Copy link
Member Author

Can you say more Ben? Why Settings? We were thinking about this as a "clickable" option within the Editor so that the user can verify the magic rewrite before saving the flow, viewing the revision history to validate what changed, etc. This wasn't meant as a fully automated solution

@Ben8t
Copy link
Member

Ben8t commented Dec 16, 2024

Oh yes definitely a clickable thing like in the screenshot you shared. Forget to add "also" in my comment: we discussed with Milos/Florian about this one and we might want to automate the rewrite automatically - especially for users only using Kestra interface.
Edited my comment as something optional or follow-up. Clickable and verification before saving is definitely the first objective here, I agree 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend Needs backend code changes area/frontend Needs frontend code changes enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants