Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Being able to remove a filter in the search using the Backspace key. #6404

Open
Tracked by #6259
Nico-Kestra opened this issue Dec 11, 2024 · 14 comments
Open
Tracked by #6259
Labels
area/frontend Needs frontend code changes enhancement New feature or request good first issue Great issue for new contributors

Comments

@Nico-Kestra
Copy link
Member

Feature description

It’s all in the title! :-)

@Nico-Kestra Nico-Kestra added area/backend Needs backend code changes enhancement New feature or request area/frontend Needs frontend code changes labels Dec 11, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Dec 11, 2024
@MilosPaunovic
Copy link
Member

You can do that already @Nico-Kestra.

@MilosPaunovic MilosPaunovic removed the area/backend Needs backend code changes label Dec 11, 2024
@MilosPaunovic MilosPaunovic self-assigned this Dec 11, 2024
@Nico-Kestra
Copy link
Member Author

Ah yes, indeed, for the ones I add, but not for the default one (absolute date) when I first arrive on the page.

@MilosPaunovic MilosPaunovic removed their assignment Dec 11, 2024
@MilosPaunovic MilosPaunovic added the good first issue Great issue for new contributors label Dec 11, 2024
@satvik2131
Copy link
Contributor

Hi @Nico-Kestra , I guess I am able to do it , correct me if it's the wrong thing .

Screencast.From.2024-12-14.19-04-37.mp4

@Piyush-r-bhaskar
Copy link
Contributor

Piyush-r-bhaskar commented Dec 15, 2024

Hi @Nico-Kestra , I guess I am able to do it , correct me if it's the wrong thing .

Screencast.From.2024-12-14.19-04-37.mp4

@satvik2131 could you add more filters and check how backspace is working in Dashboard only ?

@satvik2131
Copy link
Contributor

Hi @Nico-Kestra , I guess I am able to do it , correct me if it's the wrong thing .

Screencast.From.2024-12-14.19-04-37.mp4

@satvik2131 could you add more filters and check how backspace is working in Dashboard only ?

Screencast.From.2024-12-15.13-24-01.mp4

Like this ?

@Piyush-r-bhaskar
Copy link
Contributor

Hi @Nico-Kestra , I guess I am able to do it , correct me if it's the wrong thing .

Screencast.From.2024-12-14.19-04-37.mp4

@satvik2131 could you add more filters and check how backspace is working in Dashboard only ?

Screencast.From.2024-12-15.13-24-01.mp4

Like this ?

Yes..but 3-4 filters.

@satvik2131
Copy link
Contributor

Hi @Nico-Kestra , I guess I am able to do it , correct me if it's the wrong thing .

Screencast.From.2024-12-14.19-04-37.mp4

@satvik2131 could you add more filters and check how backspace is working in Dashboard only ?

Screencast.From.2024-12-15.13-24-01.mp4

Like this ?

Yes..but 3-4 filters.

Screencast.From.2024-12-15.13-36-38.mp4

I have added several filters as well , if this is also not the case , can you share a screen recording showing the issue .

@Piyush-r-bhaskar
Copy link
Contributor

Hi @Nico-Kestra , I guess I am able to do it , correct me if it's the wrong thing .

Screencast.From.2024-12-14.19-04-37.mp4

@satvik2131 could you add more filters and check how backspace is working in Dashboard only ?

Screencast.From.2024-12-15.13-24-01.mp4

Like this ?

Yes..but 3-4 filters.

Screencast.From.2024-12-15.13-36-38.mp4
I have added several filters as well , if this is also not the case , can you share a screen recording showing the issue .

Perfect...issue was not able to remove for the default one (absolute date). & it's looks good as per recording.
why don't you raise a PR for @MilosPaunovic to review and merge.

@satvik2131
Copy link
Contributor

Hi @Nico-Kestra , I guess I am able to do it , correct me if it's the wrong thing .

Screencast.From.2024-12-14.19-04-37.mp4

@satvik2131 could you add more filters and check how backspace is working in Dashboard only ?

Screencast.From.2024-12-15.13-24-01.mp4

Like this ?

Yes..but 3-4 filters.

Screencast.From.2024-12-15.13-36-38.mp4
I have added several filters as well , if this is also not the case , can you share a screen recording showing the issue .

Perfect...issue was not able to remove for the default one (absolute date). & it's looks good as per recording. why don't you raise a PR for @MilosPaunovic to review and merge.

Hi @Nico-Kestra , I guess I am able to do it , correct me if it's the wrong thing .

Screencast.From.2024-12-14.19-04-37.mp4

@satvik2131 could you add more filters and check how backspace is working in Dashboard only ?

Screencast.From.2024-12-15.13-24-01.mp4

Like this ?

Yes..but 3-4 filters.

Screencast.From.2024-12-15.13-36-38.mp4
I have added several filters as well , if this is also not the case , can you share a screen recording showing the issue .

Perfect...issue was not able to remove for the default one (absolute date). & it's looks good as per recording. why don't you raise a PR for @MilosPaunovic to review and merge.

I have not made any changes , it's default

@Piyush-r-bhaskar
Copy link
Contributor

Hi @Nico-Kestra , I guess I am able to do it , correct me if it's the wrong thing .

Screencast.From.2024-12-14.19-04-37.mp4

@satvik2131 could you add more filters and check how backspace is working in Dashboard only ?

Screencast.From.2024-12-15.13-24-01.mp4

Like this ?

Yes..but 3-4 filters.

Screencast.From.2024-12-15.13-36-38.mp4
I have added several filters as well , if this is also not the case , can you share a screen recording showing the issue .

Perfect...issue was not able to remove for the default one (absolute date). & it's looks good as per recording. why don't you raise a PR for @MilosPaunovic to review and merge.

Hi @Nico-Kestra , I guess I am able to do it , correct me if it's the wrong thing .

Screencast.From.2024-12-14.19-04-37.mp4

@satvik2131 could you add more filters and check how backspace is working in Dashboard only ?

Screencast.From.2024-12-15.13-24-01.mp4

Like this ?

Yes..but 3-4 filters.

Screencast.From.2024-12-15.13-36-38.mp4
I have added several filters as well , if this is also not the case , can you share a screen recording showing the issue .

Perfect...issue was not able to remove for the default one (absolute date). & it's looks good as per recording. why don't you raise a PR for @MilosPaunovic to review and merge.

I have not made any changes , it's default

Yes, we can do backspace and remove for those added manually already but here issue was only for default filter selected as it was not being removed on backspace Now it should be resolved from your change.

@satvik2131
Copy link
Contributor

@Piyush-r-bhaskar , actually , I have not made any changes , I guess it would have fixed in any recent commits , can you try switching to develop branch and check if the issue still there ?

@Piyush-r-bhaskar
Copy link
Contributor

Filter.mp4

For me issue is still there with updated develop branch.

@satvik2131
Copy link
Contributor

yup got it , just took latest pull and getting the issue , will check the cause .

satvik2131 added a commit to satvik2131/kestra that referenced this issue Dec 21, 2024
@satvik2131
Copy link
Contributor

satvik2131 commented Dec 21, 2024

@Piyush-r-bhaskar and @MilosPaunovic , I have added a fix , please check the PR and let me know if there is some issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Needs frontend code changes enhancement New feature or request good first issue Great issue for new contributors
Projects
Status: Backlog
Development

No branches or pull requests

4 participants