Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: Add explicit revision ID #80

Open
spbnick opened this issue Jun 4, 2024 · 0 comments
Open

schema: Add explicit revision ID #80

spbnick opened this issue Jun 4, 2024 · 0 comments

Comments

@spbnick
Copy link
Collaborator

spbnick commented Jun 4, 2024

Right now revisions are identified by two checkout fields: git_commit_hash and patchset_hash. However, this gets cumbersome once we need to refer to them more often. E.g. like in the upcoming "transitions".

This will especially be a problem if we ever get a DAG database with revision connectivity information. In the current plans the node key is supposed to be a hash, and we don't have one right now for revisions.

So we need to come up with one. Perhaps we should add another required field to checkouts: revision_hash and define it as e.g. a hash over git_commit_hash followed by patch file hashes in order of application. Or rather, to be able to migrate the existing data, we might need to do a hash over git_commit_hash and patchset_hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant